Skip to content

Failure to cleanup temporary directory on crash #621

@craigraw

Description

@craigraw

When HWI experiences a crash (which can happen for example when Ledger Live is also running), pyinstaller fails to delete the temporary directory it creates when expanding hwi into a directly executable form. A couple of Sparrow users have reported that if executed multiple times in this situation, the tmp directory gradually fills up with 50Mb folders that look like _MEIxxxxxx.

As I noted in sparrowwallet/sparrow#629, this is a known (and old) issue in pyinstaller that has only very recently been fixed. I'm opening this issue to track an update to the pyinstaller dependency in HWI.

Fwiw, I still believe that a --onedir build for HWI makes more sense however, particularly wrt MacOS (see #327) but also in general since expanding 50Mb folders on every invocation does not seem very efficient :) I have been using this approach for some years now on MacOS and it has proven to be preferable IMHO, at least for application developers.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions