Skip to content

httpserver: delete libevent!

Cirrus CI / tidy failed Mar 13, 2025 in 18m 21s

Task Summary

Instruction ci failed in 18:12

Details

✅ 00:04 clone
✅ 00:01 merge_base
❌ 18:12 ci

[15:51:03.625] [663/666][5.5s] clang-tidy-19 -p=/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu -quiet -load=/tidy-build/libbitcoin-tidy.so /ci_container_base/src/test/fuzz/descriptor_parse.cpp
[15:51:03.625] 697 warnings generated.
[15:51:03.625] 
[15:51:03.625] [664/666][10.2s] clang-tidy-19 -p=/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu -quiet -load=/tidy-build/libbitcoin-tidy.so /ci_container_base/src/test/miner_tests.cpp
[15:51:03.625] 1357 warnings generated.
[15:51:03.625] 
[15:51:44.229] [665/666][12.3s] clang-tidy-19 -p=/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu -quiet -load=/tidy-build/libbitcoin-tidy.so /ci_container_base/src/wallet/test/feebumper_tests.cpp
[15:51:44.229] 2005 warnings generated.
[15:51:44.229] 
[15:51:44.229] [666/666][53.7s] clang-tidy-19 -p=/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu -quiet -load=/tidy-build/libbitcoin-tidy.so /ci_container_base/src/bench/rpc_blockchain.cpp
[15:51:44.229] 1132 warnings generated.
[15:51:44.229] 
[15:51:44.263] + grep -C5 'error: ' tmp.tidy-out.txt
[15:51:44.339] 
[15:51:44.339] [426/666][6.3s] clang-tidy-19 -p=/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu -quiet -load=/tidy-build/libbitcoin-tidy.so /ci_container_base/src/rpc/signmessage.cpp
[15:51:44.339] 808 warnings generated.
[15:51:44.339] 
[15:51:44.339] [427/666][8.7s] clang-tidy-19 -p=/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu -quiet -load=/tidy-build/libbitcoin-tidy.so /ci_container_base/src/httpserver.cpp
[15:51:44.339] /ci_container_base/src/httpserver.cpp:344:21: error: the variable 'line' is copy-constructed from a const reference but is only used as const reference; consider making it a const reference [performance-unnecessary-copy-initialization,-warnings-as-errors]
[15:51:44.339]   344 |         std::string line = *maybe_line;
[15:51:44.339]       |                     ^
[15:51:44.339]       |         const      &
[15:51:44.339] /ci_container_base/src/httpserver.cpp:386:17: error: the variable 'request_line' is copy-constructed from a const reference but is only used as const reference; consider making it a const reference [performance-unnecessary-copy-initialization,-warnings-as-errors]
[15:51:44.339]   386 |     std::string request_line = *maybe_line;
[15:51:44.339]       |                 ^
[15:51:44.339]       |     const      &
[15:51:44.339] /ci_container_base/src/httpserver.cpp:495:37: error: 'find' called with a string literal consisting of a single character; consider using the more effective overload accepting a character [performance-faster-string-find,-warnings-as-errors]
[15:51:44.339]   495 |     size_t start = decoded_uri.find("?");
[15:51:44.339]       |                                     ^~~
[15:51:44.339]       |                                     '?'
[15:51:44.339] /ci_container_base/src/httpserver.cpp:497:35: error: 'find' called with a string literal consisting of a single character; consider using the more effective overload accepting a character [performance-faster-string-find,-warnings-as-errors]
[15:51:44.339]   497 |     size_t end = decoded_uri.find("#", start);
[15:51:44.339]       |                                   ^~~
[15:51:44.339]       |                                   '#'
[15:51:44.339] /ci_container_base/src/httpserver.cpp:505:35: error: 'find' called with a string literal consisting of a single character; consider using the more effective overload accepting a character [performance-faster-string-find,-warnings-as-errors]
[15:51:44.339]   505 |         size_t delim = param.find("=");
[15:51:44.339]       |                                   ^~~
[15:51:44.339]       |                                   '='
[15:51:44.339] 799 warnings generated.
[15:51:44.339] 
[15:51:44.339] --
[15:51:44.339] 
[15:51:44.339] [630/666][4.2s] clang-tidy-19 -p=/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu -quiet -load=/tidy-build/libbitcoin-tidy.so /ci_container_base/src/policy/packages.cpp
[15:51:44.339] 540 warnings generated.
[15:51:44.339] 
[15:51:44.339] [631/666][8.5s] clang-tidy-19 -p=/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu -quiet -load=/tidy-build/libbitcoin-tidy.so /ci_container_base/src/test/httpserver_tests.cpp
[15:51:44.339] /ci_container_base/src/test/httpserver_tests.cpp:14:21: error: using decl 'HTTPClient' is unused [misc-unused-using-decls,-warnings-as-errors]
[15:51:44.339]    14 | using http_bitcoin::HTTPClient;
[15:51:44.339]       |                     ^
[15:51:44.339] /ci_container_base/src/test/httpserver_tests.cpp:14:21: note: remove the using
[15:51:44.339]    14 | using http_bitcoin::HTTPClient;
[15:51:44.339]       | ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
[15:51:44.339] ^^^ ⚠️ Failure generated from clang-tidy
[15:51:44.339] + echo '^^^ ⚠️ Failure generated from clang-tidy'
[15:51:44.339] + false
��������