[QT] Show more descriptive label for pay to yourself entries #9985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasDorier
force-pushed
the
watchonlylabel
branch
from
10e5e17 to
bbfdb8d
Compare
Member
|
Concept ACK |
| parts.append(TransactionRecord(hash, nTime, TransactionRecord::SendToSelf, "", | ||
| std::string address; | ||
| CTxDestination destAddress; | ||
| if (wtx.tx->vout.size() >= 1 && ExtractDestination(wtx.tx->vout[0].scriptPubKey, destAddress)) |
Contributor
There was a problem hiding this comment.
This list only the first to-yourself-output. But I think this is okay.
|
For 'send to yourself' transactions, maybe the row-background shading should be tinted a different colour. So it is more visually apparent what transactions leave the wallet? |
Member
|
I think it may be a good idea to just remove send-to-self as a thing. In some cases (eg, CoinJoins), it is indistinguishable from send-to-someone-else + receive-from-someone-else in the same transaction... |
Contributor
Author
Contributor
Author
|
@luke-jr an alternative would be to not consider watch-only as "self". |
Member
|
CoinJoins aren't necessarily watch-only. |
Contributor
Author
|
I think #10007 is superior alternative. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This show a more descriptive label for Pay To Yourself transaction entries in bitcoin QT. Showing the label of the first Output.
Before:
After:
Pay to yourself is common when using Bitcoin Core for tracking coins going from and to Watch-Only addresses. For example, in the case of TumblerBit, it will make it easier to see when a coins is transitioning throught different states: Wallet =>Alice Escrow => Alice Offer => Alice Offer Redeem.