devtools: Make github-merge compute SHA512 from git, instead of worktree #9984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes tree_sha512sum() to requests the objects for hashing from git instead of from the working tree. The change should make the process more deterministic (it hashes what will be pushed) and hopefully avoids the frequent miscomputed SHA512's that happen now.
Member
|
utACK a327e8e
…On Mon, Mar 13, 2017 at 4:15 PM, Wladimir J. van der Laan ***@***.***> wrote:
This changes tree_sha512sum() to requests the objects for hashing from git
instead of from the working tree.
The change should make the process more deterministic (it hashes what will
be pushed) and hopefully avoids the frequent miscomputed SHA512's that
happen now.
________________________________
You can view, comment on, or merge this pull request online at:
#9984
Commit Summary
devtools: Make github-merge compute SHA512 from git, instead of worktree
File Changes
M contrib/devtools/github-merge.py (45)
Patch Links:
https://github.com/bitcoin/bitcoin/pull/9984.patch
https://github.com/bitcoin/bitcoin/pull/9984.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Member
Author
|
@MarcoFalke thanks |
laanwj
added a commit
that referenced
this pull request
Mar 14, 2017
…tead of worktree a327e8e devtools: Make github-merge compute SHA512 from git, instead of worktree (Wladimir J. van der Laan) Tree-SHA512: 22ec7712876be4ab361015a2dd75a09628ec59105ffe3260126f899d8f3ff8666351b65b9a4dfe83f78eb777730442cd0352b155d7f573424f7fc1c4dbc0ddd2
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Feb 26, 2019
…it, instead of worktree a327e8e devtools: Make github-merge compute SHA512 from git, instead of worktree (Wladimir J. van der Laan) Tree-SHA512: 22ec7712876be4ab361015a2dd75a09628ec59105ffe3260126f899d8f3ff8666351b65b9a4dfe83f78eb777730442cd0352b155d7f573424f7fc1c4dbc0ddd2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes tree_sha512sum() to requests the objects for hashing from git instead of from the working tree.
The change should make the process more deterministic (it hashes what will be pushed) and hopefully avoids the frequent miscomputed SHA512's that happen now.
As an added bonus this can now compute treehashes for non-HEAD commits, although this functionality is not used.