Skip to content

Improve readability of segwit.py, smartfees.py #9970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laanwj merged 2 commits into from
Mar 14, 2017
Merged

Improve readability of segwit.py, smartfees.py #9970

laanwj merged 2 commits into from
Mar 14, 2017

Conversation

@sdaftuar
Copy link
Member

@sdaftuar sdaftuar commented Mar 10, 2017 •
edited
Loading

More work is surely needed, but I tried to clean up some hard-to-understand helper functions.

Also fixed a logging bug in smartfees.py (introduced in #9768).

@sdaftuar sdaftuar force-pushed the 2017-03-segwit-test-improvements branch from 21b76b5 to fede1cb Compare March 10, 2017 16:41
@sdaftuar
Copy link
Member Author

sdaftuar commented Mar 10, 2017

Force-pushed with a fix to bumpfee.py (forgot it was using one of the helpers I changed).

@sdaftuar sdaftuar changed the title Improve readability of segwit.py Improve readability of segwit.py, smartfees.py Mar 10, 2017
@maflcko maflcko added the Tests label Mar 10, 2017
@maflcko maflcko mentioned this pull request Mar 10, 2017
Closed
@jnewbery jnewbery mentioned this pull request Mar 10, 2017
Merged
@sdaftuar sdaftuar force-pushed the 2017-03-segwit-test-improvements branch from bc9a01a to 1269b8a Compare March 11, 2017 02:13
@sdaftuar
Copy link
Member Author

sdaftuar commented Mar 11, 2017

Rebased after #9768

@laanwj
Copy link
Member

laanwj commented Mar 14, 2017

utACK 1269b8a
See also #9983, there I converted the segwit test as well as a few others to use named arguments for RPCs everywhere.

@laanwj laanwj merged commit 1269b8a into bitcoin:master Mar 14, 2017
laanwj added a commit that referenced this pull request Mar 14, 2017
@laanwj
Merge #9970: Improve readability of segwit.py, smartfees.py
3cc13ea 
1269b8a Fix logging bug and improve readability of smartfees.py (Suhas Daftuar)
b9f34e8 Improve readability of segwit.py (Suhas Daftuar)

Tree-SHA512: 2c8ff61678c6c407a95a6530e9bd650ae6bb7c9e52f6dd5f256e19253a1358dd1a7aa33a9639fcb07f443e3a21dae71b9f0865c5f1fcaacb2097a3c6766c7eef
@laanwj laanwj mentioned this pull request Mar 14, 2017
Merged
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Feb 26, 2019
@laanwj @PastaPastaPasta
Merge bitcoin#9970: Improve readability of segwit.py, smartfees.py
c17356e 
1269b8a Fix logging bug and improve readability of smartfees.py (Suhas Daftuar)
b9f34e8 Improve readability of segwit.py (Suhas Daftuar)

Tree-SHA512: 2c8ff61678c6c407a95a6530e9bd650ae6bb7c9e52f6dd5f256e19253a1358dd1a7aa33a9639fcb07f443e3a21dae71b9f0865c5f1fcaacb2097a3c6766c7eef
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sdaftuar @laanwj @maflcko