Fix shutdown hang with >= 8 -addnodes set #9953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
force-pushed
the
2017-03-exit-with-addnode
branch
from
8ac941c to
569b6ee
Compare
Closed
Member
|
|
We previously would block waiting for a CSemaphoreGrant in ThreadOpenAddedConnections, when we did not need to. This would block as the posts in CConnman shutdown were both to the wrong semaphore and in the wrong location.
TheBlueMatt
force-pushed
the
2017-03-exit-with-addnode
branch
from
569b6ee to
e007b24
Compare
Contributor
Author
|
Changed the fix to post to semAddnode instead of TryAcquire. |
gmaxwell
approved these changes
Mar 8, 2017
Contributor
gmaxwell
left a comment
gmaxwell
left a comment
There was a problem hiding this comment.
utACK. (will test) Thanks.
Member
|
utACK 819b513 |
1 similar comment
Contributor
|
utACK 819b513 |
Contributor
|
Should fix: #9950 |
TheBlueMatt
added a commit
to TheBlueMatt/bitcoin
that referenced
this pull request
Mar 17, 2017
We previously would block waiting for a CSemaphoreGrant in ThreadOpenAddedConnections, when we did not need to. This would block as the posts in CConnman shutdown were both to the wrong semaphore and in the wrong location. Github-Pull: bitcoin#9953 Rebased-From: e007b24
TheBlueMatt
added a commit
to TheBlueMatt/bitcoin
that referenced
this pull request
Mar 17, 2017
Github-Pull: bitcoin#9953 Rebased-From: 819b513
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Jan 5, 2019
We previously would block waiting for a CSemaphoreGrant in ThreadOpenAddedConnections, when we did not need to. This would block as the posts in CConnman shutdown were both to the wrong semaphore and in the wrong location. Github-Pull: bitcoin#9953 Rebased-From: e007b24
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Jan 5, 2019
Github-Pull: bitcoin#9953 Rebased-From: 819b513
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously would block waiting for a CSemaphoreGrant, when we
did not need to.