Fix RPC failure testing (continuation of #9707) #9842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the cleanup. Factor out the try/catches makes the tests much more readable. |
jtimon
reviewed
Mar 7, 2017
qa/rpc-tests/blockchain.py
Outdated
| assert_is_hash_string, | ||
| start_nodes, | ||
| connect_nodes_bi, | ||
| connect_nodes_bi |
Contributor
There was a problem hiding this comment.
I don't think you need to remove the coma here.
Contributor
Author
|
rebased and reverted the comma removal: jnewbery@c3d6c83 / https://github.com/jnewbery/bitcoin/tree/pr9842.2 |
Contributor
Author
Contributor
Author
|
oops. Merge issues from priority removal. Should be fixed now. |
jnewbery
force-pushed
the
rpctestassert2
branch
2 times, most recently
from
cff1b40 to
364db21
Compare
Contributor
Author
|
rebased |
Commit 9db8eec improved the assert_raises_jsonrpc() function for better testing of RPC failure modes. This commit completes the job by removing remaining broken try-except RPC testing from the individual test cases and replacing it with calls to assert_raises_jsonrpc().
jnewbery
force-pushed
the
rpctestassert2
branch
from
364db21 to
c9bd0f6
Compare
Contributor
Author
|
rebased. Any chance of getting this merged soon? |
Member
|
utACK c9bd0f6 |
maflcko
pushed a commit
that referenced
this pull request
Mar 16, 2017
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
May 6, 2019
…9707) c9bd0f6 Fix RPC failure testing (2 of 2) (John Newbery) Tree-SHA512: df30e6e85abe8c4e12910dc60699f1201e9c243457abd738c1fdeac45f0ff05c674f68619ad9a47c847ec557954007d672cd89d3a9a3b2398dd188d9ffa6dcc9 s/serialize_with_witness/serialize/ miss a tx_submit -> sendrawtransaction dropped dip4 Fix tests Signed-off-by: Pasta <[email protected]> Fix file permissions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 9db8eec improved the
assert_raises_jsonrpc() function for better testing of RPC failure
modes. This commit continues the job by removing remaining broken
try-except RPC testing from individual test cases and replacing it
with calls to assert_raises_jsonrpc().
Note that this does not fully complete the job. This commit replaces the try/except code with assert_raises_jsonrpc() only for those test cases where no changes to bitcoind were required (ie the test cases weren't necessarily fully testing the behaviour, but the behaviour was correct anyway). For any test cases where fixing the test code has revealed bugs or inconsistencies, I'll raise a separate issue/PR (eg #9738, #9714, #9841, #9710). There are a few more of those to come.