Trivial: fix comments referencing AppInit2 #9833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laanwj
reviewed
Feb 23, 2017
src/init.cpp
Outdated
Member
There was a problem hiding this comment.
let's just remove mention of a function here and call it "initialization". It may be any of the initialization-related functions that failed.
Author
There was a problem hiding this comment.
Done (also in bitcoin.cpp).
For my information: how should I address feedback: with new commits for easier review, or with amending? I amended this time.
Member
There was a problem hiding this comment.
For documentation/string commits like this, amending is best IMO.
For more involved commits, it can make sense to keep a history, at least until merge.
laanwj
reviewed
Feb 23, 2017
src/init.cpp
Outdated
Member
There was a problem hiding this comment.
This is no longer true, by the way. Since #9010, the -daemon handling is in bitcoind.cpp, not in init.cpp.
Author
There was a problem hiding this comment.
Thanks. The comment seems to not be true anyway, so I removed it altogether.
It was refactored into multiple functions in 0cc8b6b.
Member
|
utACK ef9f495 |
Contributor
|
utACK ef9f495 |
laanwj
added a commit
that referenced
this pull request
Feb 24, 2017
ef9f495 Trivial: fix comments referencing AppInit2 (Marko Bencun)
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jan 3, 2019
ef9f495 Trivial: fix comments referencing AppInit2 (Marko Bencun)
UdjinM6
pushed a commit
to dashpay/dash
that referenced
this pull request
Jan 7, 2019
* Merge bitcoin#9815: Trivial: use EXIT_ codes instead of magic numbers a87d02a use EXIT_ codes instead of magic numbers (Marko Bencun) * Merge bitcoin#9801: Removed redundant parameter from mempool.PrioritiseTransaction eaea2bb Removed redundant parameter from mempool.PrioritiseTransaction (gubatron) * remove extra parameter (see 3a3745bb) in dash specific code * Merge bitcoin#9819: Remove harmless read of unusued priority estimates bc8fd12 Remove harmless read of unusued priority estimates (Alex Morcos) * Merge bitcoin#9766: Add --exclude option to rpc-tests.py c578408 Add exclude option to rpc-tests.py (John Newbery) * Merge bitcoin#9577: Fix docstrings in qa tests 3f95a80 Fix docstrings in qa tests (John Newbery) * Merge bitcoin#9823: qa: Set correct path for binaries in rpc tests 3333ad0 qa: Set correct path for binaries in rpc tests (MarcoFalke) * Merge bitcoin#9833: Trivial: fix comments referencing AppInit2 ef9f495 Trivial: fix comments referencing AppInit2 (Marko Bencun) * Merge bitcoin#9612: [trivial] Rephrase the definition of difficulty. dc222f8 Trivial: Rephrase the definition of difficulty in the code. (Karl-Johan Alm) * Merge bitcoin#9847: Extra test vector for BIP32 30aedcb BIP32 extra test vector (Pieter Wuille) * Merge bitcoin#9839: [qa] Make import-rescan.py watchonly check reliable 864890a [qa] Make import-rescan.py watchonly check reliable (Russell Yanofsky) Tree-SHA512: ea0e2b1d4fc8f35174c3d575fb751b428daf6ad3aa944fad4e3ddcc9195e4f17051473acabc54203b1d27cca64cf911b737ab92e986c40ef384410652e2dbea1 * Change back file params
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was refactored into multiple functions in
0cc8b6b.