Removed redundant parameter from mempool.PrioritiseTransaction #9801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasschnelli
approved these changes
Feb 19, 2017
Contributor
jonasschnelli
left a comment
jonasschnelli
left a comment
There was a problem hiding this comment.
Makes sense. Thanks.
utACK 8e88a445dc9de71657282a461cb6b679c9079ebd
Contributor
|
ACK 8e88a44 |
dcousens
approved these changes
Feb 20, 2017
Member
|
utACK 8e88a44
|
sdaftuar
reviewed
Feb 21, 2017
src/txmempool.cpp
Outdated
Member
There was a problem hiding this comment.
Perhaps while you're at it you could make this const uint256& hash?
Contributor
Author
There was a problem hiding this comment.
done deal, thanks.
(squashed and rebased)
maflcko
reviewed
Feb 21, 2017
src/txmempool.h
Outdated
Member
There was a problem hiding this comment.
The redundant parameter is not removed, as mentioned in the commit message.
Member
There was a problem hiding this comment.
You can run make check locally as a quick sanity check.
Contributor
Author
There was a problem hiding this comment.
yes, something got screwed with the rebase, re-uploaded now. Thanks.
(Also made the `const uint256 hash` parameter a `const uint256& hash` as suggested by @sdaftuar)
Contributor
|
ACK eaea2bb |
Member
|
utACK eaea2bb |
laanwj
added a commit
that referenced
this pull request
Feb 22, 2017
…action eaea2bb Removed redundant parameter from mempool.PrioritiseTransaction (gubatron)
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jan 3, 2019
…seTransaction eaea2bb Removed redundant parameter from mempool.PrioritiseTransaction (gubatron)
UdjinM6
pushed a commit
to dashpay/dash
that referenced
this pull request
Jan 7, 2019
* Merge bitcoin#9815: Trivial: use EXIT_ codes instead of magic numbers a87d02a use EXIT_ codes instead of magic numbers (Marko Bencun) * Merge bitcoin#9801: Removed redundant parameter from mempool.PrioritiseTransaction eaea2bb Removed redundant parameter from mempool.PrioritiseTransaction (gubatron) * remove extra parameter (see 3a3745bb) in dash specific code * Merge bitcoin#9819: Remove harmless read of unusued priority estimates bc8fd12 Remove harmless read of unusued priority estimates (Alex Morcos) * Merge bitcoin#9766: Add --exclude option to rpc-tests.py c578408 Add exclude option to rpc-tests.py (John Newbery) * Merge bitcoin#9577: Fix docstrings in qa tests 3f95a80 Fix docstrings in qa tests (John Newbery) * Merge bitcoin#9823: qa: Set correct path for binaries in rpc tests 3333ad0 qa: Set correct path for binaries in rpc tests (MarcoFalke) * Merge bitcoin#9833: Trivial: fix comments referencing AppInit2 ef9f495 Trivial: fix comments referencing AppInit2 (Marko Bencun) * Merge bitcoin#9612: [trivial] Rephrase the definition of difficulty. dc222f8 Trivial: Rephrase the definition of difficulty in the code. (Karl-Johan Alm) * Merge bitcoin#9847: Extra test vector for BIP32 30aedcb BIP32 extra test vector (Pieter Wuille) * Merge bitcoin#9839: [qa] Make import-rescan.py watchonly check reliable 864890a [qa] Make import-rescan.py watchonly check reliable (Russell Yanofsky) Tree-SHA512: ea0e2b1d4fc8f35174c3d575fb751b428daf6ad3aa944fad4e3ddcc9195e4f17051473acabc54203b1d27cca64cf911b737ab92e986c40ef384410652e2dbea1 * Change back file params
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The string parameter is used only for logging.
The only place where the
stringform of the hash isn't recalculated is atsrc/rpc/mining.cppwhere it's obtained from the arguments, however, in this case theuint256hash is then parsed from the givenstring.In every other use of the function, the
stringrepresentation is always calculated from theuint256 hashobject (either withToString()or withGetHash()), so no real benefit on having this redundant parameter.This also makes the API more consistent with other methods that only receive the
uint256hash parameter.