Skip to content

Qt/Intro: Various fixes #9718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laanwj merged 3 commits into from
Feb 9, 2017
Merged

Qt/Intro: Various fixes #9718

laanwj merged 3 commits into from
Feb 9, 2017

Conversation

@luke-jr
Copy link
Member

@luke-jr luke-jr commented Feb 8, 2017 •
edited
Loading

No description provided.

@fanquake fanquake added the GUI label Feb 8, 2017
@maflcko
Copy link
Member

maflcko commented Feb 8, 2017

ACK on bumping the minimum, as this is part of the release process https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md#release-process

Would be great if someone could prepare a pull for all those bumps, so it could be done prior to the branch off.

Not sure if the other changes should go into 0.14.

@laanwj
Copy link
Member

laanwj commented Feb 8, 2017

At least the changes that change translation messages cannot go into 0.14.

@luke-jr luke-jr force-pushed the intro_fixes branch 2 times, most recently from e61c940 to 5bb2a5e Compare February 8, 2017 16:29
@luke-jr
Copy link
Member Author

luke-jr commented Feb 8, 2017

Stripped out the translation-touching stuff for now. I think this is good for 0.14.

@fanquake fanquake added this to the 0.14.0 milestone Feb 8, 2017
@luke-jr luke-jr mentioned this pull request Feb 8, 2017
Merged
@paveljanik
Copy link
Contributor

paveljanik commented Feb 8, 2017

ACK 5bb2a5e

TheBlueMatt
TheBlueMatt reviewed Feb 8, 2017
View reviewed changes
src/qt/intro.cpp Outdated
Copy link
Contributor

@TheBlueMatt TheBlueMatt Feb 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems low.

118G /mnt/bitcoin/blocks

Copy link
Contributor

@TheBlueMatt TheBlueMatt Feb 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of which only

9.4G /mnt/bitcoin/blocks/index

(-txindex).

Copy link
Member Author

@luke-jr luke-jr Feb 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still store stale blocks forever (but those won't be downloaded in IBD).

Copy link
Contributor

@TheBlueMatt TheBlueMatt Feb 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is on a node which started sync last week, so it shouldnt have many stale blocks.

@maflcko
Copy link
Member

maflcko commented Feb 8, 2017 via email

@luke-jr
Copy link
Member Author

luke-jr commented Feb 8, 2017

Okay, bumped it to 120.

@sipa
Copy link
Member

sipa commented Feb 8, 2017

utACK a9baa6d

1 similar comment
@achow101
Copy link
Member

achow101 commented Feb 8, 2017

utACK a9baa6d

@TheBlueMatt
Copy link
Contributor

TheBlueMatt commented Feb 8, 2017

I would hesitate to call this a bugfix that needs to happen last-hour for 0.14, as it seems rather inconsequential, but utACK a9baa6d.

@paveljanik
Copy link
Contributor

paveljanik commented Feb 8, 2017

reACK a9baa6d

@sipa
Copy link
Member

sipa commented Feb 8, 2017

Agree it's mostly an improvement, but we should get the blockchain size estimate update in.

@maflcko
Copy link
Member

maflcko commented Feb 8, 2017 via email

@laanwj laanwj merged commit a9baa6d into bitcoin:master Feb 9, 2017
laanwj added a commit that referenced this pull request Feb 9, 2017
@laanwj
Merge #9718: Qt/Intro: Various fixes
36f9d3a 
a9baa6d Bugfix: Qt/Intro: Pruned nodes never require *more* space (Luke Dashjr)
93ffba7 Bugfix: Qt/Intro: Chain state needs to be stored even with the full blockchain (Luke Dashjr)
c8cee26 Qt/Intro: Update block chain size (Luke Dashjr)
codablock pushed a commit to codablock/dash that referenced this pull request Jan 23, 2018
@laanwj @codablock
Merge bitcoin#9718: Qt/Intro: Various fixes
f1f4e25 
a9baa6d Bugfix: Qt/Intro: Pruned nodes never require *more* space (Luke Dashjr)
93ffba7 Bugfix: Qt/Intro: Chain state needs to be stored even with the full blockchain (Luke Dashjr)
c8cee26 Qt/Intro: Update block chain size (Luke Dashjr)
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
@laanwj @andvgal
Merge bitcoin#9718: Qt/Intro: Various fixes
b9ad99e 
a9baa6d Bugfix: Qt/Intro: Pruned nodes never require *more* space (Luke Dashjr)
93ffba7 Bugfix: Qt/Intro: Chain state needs to be stored even with the full blockchain (Luke Dashjr)
c8cee26 Qt/Intro: Update block chain size (Luke Dashjr)
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Feb 27, 2019
@laanwj @CryptoCentric
Merge bitcoin#9718: Qt/Intro: Various fixes
a213a34 
a9baa6d Bugfix: Qt/Intro: Pruned nodes never require *more* space (Luke Dashjr)
93ffba7 Bugfix: Qt/Intro: Chain state needs to be stored even with the full blockchain (Luke Dashjr)
c8cee26 Qt/Intro: Update block chain size (Luke Dashjr)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@TheBlueMatt TheBlueMatt TheBlueMatt left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

GUI

Projects

None yet

Milestone

0.14.0

Development

Successfully merging this pull request may close these issues.

8 participants

@luke-jr @maflcko @laanwj @paveljanik @sipa @achow101 @TheBlueMatt @fanquake