Access WorkQueue::running only within the cs lock #9679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes a "race" between Interrupt() and Run(), though it should not effect any of our supported platforms.
Contributor
Author
|
Can this get an 0.14 tag, since its a simple bugfix. |
Member
|
utACK 7b2d96b |
1 similar comment
Member
|
utACK 7b2d96b
|
laanwj
added a commit
that referenced
this pull request
Feb 4, 2017
7b2d96b Access WorkQueue::running only within the cs lock. (Matt Corallo)
LarryRuane
pushed a commit
to LarryRuane/zcash
that referenced
this pull request
Apr 1, 2021
This removes a "race" between Interrupt() and Run(), though it should not effect any of our supported platforms. zcash: cherry picked from commit 7b2d96b zcash: bitcoin/bitcoin#9679
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Apr 2, 2021
Bitcoin 0.14 locking PRs These are locking changes from upstream (bitcoin core) release 0.14, oldest to newest (when merged to the master branch). Each commit also includes a reference both to the PR and the upstream commit. - bitcoin/bitcoin#8472 - bitcoin/bitcoin#8606 - Excludes a lock move because we don't have bitcoin/bitcoin#7840 which this move was partially-reverting. - bitcoin/bitcoin#9230 - Only first commit (we don't have `LogTimestampStr` anymore). - bitcoin/bitcoin#9243 - Only the sixth commit, excluding `IsArgSet` locking (we haven't pulled that function in yet). - bitcoin/bitcoin#9626 - The cherry-picked commit does not match the upstream at all, but the resulting lock is useful. - bitcoin/bitcoin#9679 - bitcoin/bitcoin#9227 - bitcoin/bitcoin#9698 - Excludes change to `CConnman::PushMessage` in second commit (which we don't have yet). - bitcoin/bitcoin#9708 - bitcoin/bitcoin#9771
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a "race" between Interrupt() and Run(), though it
should not effect any of our supported platforms.