[Trivial] Grammar and typo correction (laudaa) #9610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor corrections in src\test\* .
maflcko
pushed a commit
that referenced
this pull request
Jan 22, 2017
5c66d41 [Trivial] Grammar and typo correction (Lauda)
|
Sounds good! |
Contributor
|
@MarcoFalke for the record I'm opposed to these kind of PR's |
Member
Author
|
@morcos Agree, but note that this pull was already reviewed in #9543.
I'd prefer not to close pull request once they have been reviewed and
ACKed.
I think one solution would be to mention in our contribution
guidelines that minor grammar and spelling mistakes (e.g. AE vs BE or
mostly irrelevant typographic errors in non user facing messages)
should not be fixed.
|
Contributor
|
@MarcoFalke ok thanks.. yeah or fixed only when modifying the area already... |
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 21, 2018
5c66d41 [Trivial] Grammar and typo correction (Lauda)
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Apr 4, 2018
Additional dbwrapper tests Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#7992 - bitcoin/bitcoin#9867 - Only the commit affecting dbwrapper tests - bitcoin/bitcoin#9610 - Only the change affecting dbwrapper tests - bitcoin/bitcoin#10844
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
5c66d41 [Trivial] Grammar and typo correction (Lauda)
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 27, 2019
5c66d41 [Trivial] Grammar and typo correction (Lauda)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor corrections in src\test* .
This is a squashed version of #9543, which I accidentally closed while trying to squash and force push.