Skip to content

Remove unused variables #9532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laanwj merged 2 commits into from
Feb 7, 2017
Merged

Remove unused variables #9532

laanwj merged 2 commits into from
Feb 7, 2017

Conversation

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Jan 12, 2017

No description provided.

@practicalswift practicalswift force-pushed the remove-unused-variables branch from 9de96a1 to b32a6ff Compare January 12, 2017 20:53
@maflcko maflcko mentioned this pull request Jan 12, 2017
Closed
@practicalswift practicalswift force-pushed the remove-unused-variables branch from b32a6ff to 180df23 Compare January 12, 2017 21:00
@fanquake fanquake changed the title [trivial] Remove unused variables Remove unused variables Jan 12, 2017
@fanquake
Copy link
Member

fanquake commented Jan 12, 2017

Can you please rename the commits to remove the [trivial], as that tag is really only used when a PR doesn't touch any code.

@jtimon
Copy link
Contributor

jtimon commented Jan 12, 2017

I have used "Trivial: " in the beginning of the message of some commits that changed code in trivial ways, I didn't know that policy. When I don't touch code at all I tend to just use "Doc: ", but I did these things on my own, if we have a place describing these kind of best practices I missed it, can you link to it?

@jtimon
Copy link
Contributor

jtimon commented Jan 13, 2017 •
edited
Loading

ACK 180df23

robmcl4
robmcl4 reviewed Jan 13, 2017
View reviewed changes
src/addrman.cpp Outdated
Copy link
Contributor

@robmcl4 robmcl4 Jan 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe initializing nSinceLastTry and the following if statement can be collapsed into a call to std::max().

Copy link
Contributor Author

@practicalswift practicalswift Jan 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! I'll take that in another PR!

Copy link
Contributor Author

@practicalswift practicalswift Jan 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robmcl4 Submitted as #9553 :-)

@paveljanik
Copy link
Contributor

paveljanik commented Jan 13, 2017

ACK 180df23

@practicalswift practicalswift force-pushed the remove-unused-variables branch from 180df23 to 90fd29b Compare January 13, 2017 17:55
@practicalswift
Copy link
Contributor Author

practicalswift commented Jan 13, 2017

@fanquake Removed [trivial] from the commit titles as requested :-)

@practicalswift practicalswift mentioned this pull request Jan 14, 2017
Merged
@instagibbs
Copy link
Member

instagibbs commented Jan 14, 2017

@jtimon #9542 PR about [trivial] tag

This was referenced Jan 18, 2017
Merged
Closed
@practicalswift
Copy link
Contributor Author

practicalswift commented Jan 29, 2017

I believe this one should be ready to merge. Please let me know if any adjustments are needed and I'll fix it right away! :-)

@jtimon
Copy link
Contributor

jtimon commented Feb 2, 2017 •
edited
Loading

utACK 90fd29b

@practicalswift
Copy link
Contributor Author

practicalswift commented Feb 2, 2017

Any sponsor who has time to take a look at this hopefully trivial PR? :-)

@maflcko
Copy link
Member

maflcko commented Feb 3, 2017

utACK 90fd29b

@laanwj laanwj merged commit 90fd29b into bitcoin:master Feb 7, 2017
laanwj added a commit that referenced this pull request Feb 7, 2017
@laanwj
Merge #9532: Remove unused variables
b709fe7 
90fd29b Remove unused int64_t nSinceLastSeen (practicalswift)
ac4a095 Remove unused Python variables (practicalswift)
codablock pushed a commit to codablock/dash that referenced this pull request Jan 23, 2018
@laanwj @codablock
Merge bitcoin#9532: Remove unused variables
767f5e4 
90fd29b Remove unused int64_t nSinceLastSeen (practicalswift)
ac4a095 Remove unused Python variables (practicalswift)
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
@laanwj @andvgal
Merge bitcoin#9532: Remove unused variables
8a1c7ea 
90fd29b Remove unused int64_t nSinceLastSeen (practicalswift)
ac4a095 Remove unused Python variables (practicalswift)
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Feb 27, 2019
@laanwj @CryptoCentric
Merge bitcoin#9532: Remove unused variables
da224e5 
90fd29b Remove unused int64_t nSinceLastSeen (practicalswift)
ac4a095 Remove unused Python variables (practicalswift)
@practicalswift practicalswift deleted the remove-unused-variables branch April 10, 2021 19:28
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@robmcl4 robmcl4 robmcl4 left review comments

@dcousens dcousens dcousens approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@practicalswift @fanquake @jtimon @paveljanik @instagibbs @maflcko @dcousens @robmcl4 @laanwj