[refactor] Switched httpserver.cpp to use RAII wrapped libevents. #9517
Conversation
src/httpserver.cpp
Outdated
There was a problem hiding this comment.
Because eventBase/eventHTTP are global and need them intact. If I don't release they'd be deleted on function return.
There was a problem hiding this comment.
I mean, I guess it improves consistency, and the .release(), if you added a comment noting the above about the lifetime, might be clearer than what was there before?
This change seems pointless IMHO, maybe I'm missing something
There was a problem hiding this comment.
Yeah, you're right. Addressing.
There was a problem hiding this comment.
Regarding purpose: the one thing this brings is that no matter how things end, the base and http objects will be properly cleaned up. I have no idea what kind of side-effects an initialized and forgotten event base or evhttp might have. Perhaps none whatsoever.
src/httpserver.cpp
Outdated
There was a problem hiding this comment.
What happened to the error handling? (https://github.com/bitcoin/bitcoin/blob/master/src/support/events.h#L33)
There was a problem hiding this comment.
In the case of event_base, the wrapper does the error handling already.
kallewoof
force-pushed
the
raii-httpserver
branch
from
c7d7ecf to
e23ecf7
Compare
src/httpserver.cpp
Outdated
There was a problem hiding this comment.
What about
eventBase = base_ctr.release();
eventHTTP = http_ctr.release();
There was a problem hiding this comment.
That looks much better. I didn't realize you could do that. Thanks!
kallewoof
force-pushed
the
raii-httpserver
branch
from
e23ecf7 to
0aa740c
Compare
kallewoof
force-pushed
the
raii-httpserver
branch
from
0aa740c to
fd369d2
Compare
|
Rebased. |
|
Fast review ACK |
…symbol linker errors.
kallewoof
force-pushed
the
raii-httpserver
branch
from
eb4bcb9 to
1ae86ec
Compare
gmaxwell
left a comment
gmaxwell
left a comment
There was a problem hiding this comment.
ACK (mostly tested ACK, I'm not so useful for reviewing this stuff. :) )
|
utACK 1ae86ec |
…ibevents. 1ae86ec Changed event RAII helper functions to inline to deal with duplicate symbol linker errors. (Karl-Johan Alm) fd369d2 Switched httpserver.cpp to use RAII wrapped libevents. (Kalle Alm) Tree-SHA512: 877e431f211024d42a3b0800e860e02833398611433e8393f8d5d4970f47f4bd670b900443678c067fec110c087aaab7dc1981ccbf17f6057676fdbbda89aed9
…apped libevents. 1ae86ec Changed event RAII helper functions to inline to deal with duplicate symbol linker errors. (Karl-Johan Alm) fd369d2 Switched httpserver.cpp to use RAII wrapped libevents. (Kalle Alm) Tree-SHA512: 877e431f211024d42a3b0800e860e02833398611433e8393f8d5d4970f47f4bd670b900443678c067fec110c087aaab7dc1981ccbf17f6057676fdbbda89aed9
6 participants
Continuation of #9387. I believe this concludes fixing the
// XXX RAIIplaces.