Skip to content

build: fix qt distdir builds #9509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
theuni wants to merge 1 commit into from
Closed

build: fix qt distdir builds #9509

theuni wants to merge 1 commit into from

Conversation

@theuni
Copy link
Member

@theuni theuni commented Jan 10, 2017

Just build the same way as the file above it.

Fixes the issue presented by #9416.

@theuni
Copy link
Member Author

theuni commented Jan 10, 2017

@MarcoFalke I believe this should fix your issue.

@maflcko
Copy link
Member

maflcko commented Jan 10, 2017 via email

@fanquake
Copy link
Member

fanquake commented Jan 11, 2017

OS X failed with:

Undefined symbols for architecture x86_64:
  "qInitResources_bitcoin()", referenced from:
      _main in qt_bitcoin_qt-bitcoin.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [qt/bitcoin-qt] Error 1
make[1]: Leaving directory `/home/travis/build/bitcoin/bitcoin/build/src'
make: *** [src/qt/bitcoin-qt] Error 2

Linux failed with:

qt/qt_bitcoin_qt-bitcoin.o: In function `main':
bitcoin.cpp:(.text.startup+0x13d): undefined reference to `qInitResources_bitcoin()'
collect2: error: ld returned 1 exit status
make[2]: *** [qt/bitcoin-qt] Error 1
make[2]: Leaving directory `/home/travis/build/bitcoin/bitcoin/build/src'
make[1]: *** [install-recursive] Error 1
make[1]: Leaving directory `/home/travis/build/bitcoin/bitcoin/build/src'
make: *** [install-recursive] Error 1

@theuni
Copy link
Member Author

theuni commented Jan 11, 2017

Whoops, I remember what this is doing now. This is wrong.

We need to make the distinction between generated files and unchanging files. Since these aren't changed by the build, they need to come from srcdir rather than builddir. So it's correct as-is.

@theuni theuni closed this Jan 11, 2017
@theuni theuni mentioned this pull request Jan 11, 2017
Merged
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Build system

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@theuni @maflcko @fanquake