[Qt] Add option to pause/resume block downloads #9502

jonasschnelli · 2017-01-10T17:35:57Z

This, almost UI only change, will add a Pause/Resume button to the modal overlay to pause/resume block downloads during IBD.

This is an effective way to pause/resume IBD during a time when the computers resources are required somewhere else.

paveljanik · 2017-01-10T17:37:39Z

Isn't network toggle button usable in this case? If it is not, let's fix it instead...

jonasschnelli · 2017-01-10T18:05:19Z

I extracted this from my SPV branch. Especially there, it is very useful to pause IBD and continue with SPV during a time where you don't want to use all available resources on verification.

But also without SPV, I think this can be useful (pause IBD and not loose broadcast capabilities, fetch headers but not the blocks)...

luke-jr · 2017-01-10T18:06:22Z

IMO it would be too confusing to be worth it without "SPV" mode, but probably should go in after the latter is.

maflcko · 2017-01-10T18:33:43Z

Isn't network toggle button usable in this case? If it is not, let's fix it instead...

Imo those are different features, but I agree that the GUI should not "diverge" in regard to presenting features. The toggle network functionality should be removed from the network icon and a proper button should be put beside the new "Pause" button?

luke-jr · 2017-01-10T18:44:23Z

The "Pause" button won't be visible in normal cases.

jonasschnelli · 2017-01-10T19:16:04Z

Isn't network toggle button usable in this case? If it is not, let's fix it instead...

Imo those are different features, but I agree that the GUI should not
"diverge" in regard to presenting features. The toggle network
functionality should be removed from the network icon and a proper
button should be put beside the new "Pause" button?

Yes. These are internally two completely different features. Expose to the users, these have similar effects.

The "Pause" button won't be visible in normal cases.

Yes. The modal overlay is currently only accessible during IBD. Though, we could extend it to support a state where the chain is in-sync and show it when someone click on the network statusbar icon.

kallewoof

utACK abf0941

kallewoof · 2017-02-28T22:10:24Z

src/net_processing.h

Typo: usefull (one L)

kallewoof · 2017-02-28T22:11:53Z

src/qt/clientmodel.h

Nit: isAutorequestingBlocks (add ing). The setAutorequestBlocks below is fine as is, though.

laanwj · 2017-03-14T08:57:40Z

Added 0.15 milestone

jonasschnelli · 2017-03-17T14:22:45Z

Rebased.

laanwj · 2017-04-19T10:25:54Z

src/net_processing.h


+/** if disabled, blocks will not be requested automatically, usefull for low-resources-available mode */
+static const bool DEFAULT_AUTOMATIC_BLOCK_REQUESTS = true;
+extern std::atomic<bool> fAutoRequestBlocks;


Instead of exporting this variable (whose definition is an implementation detail) from net_processing.h I'd prefer a setter/getter, e.g. SetAutoRequestBlocks(bool) GetAutoRequestBlocks()

Agree. Will change...

laanwj · 2017-04-19T10:26:36Z

src/qt/clientmodel.cpp

    return GUIUtil::boostPathToQString(GetDataDir());
 }

+bool ClientModel::isAutorequestBlocks() const


isAutorequestBlocks is a bit of a strange name; isAutoRequestingBlocks maybe?

laanwj · 2017-04-19T10:40:53Z

When re-enabling AutoRequestBlocks, what 'kicks off' the block requesting process again? Setting the flag will make it request blocks the next time FindNextBlocksToDownload is called; is that good enough? I suppose it is, because SendMessages is called periodically (every 100 ms?).

jonasschnelli · 2017-04-20T08:33:22Z

Overhauled the PR and addresses @laanwj points.

Also, I added the info "Blocks requested from peers" (blocks in flight). This may be important because pause will not result in disconnecting peers. Already requested blocks will be downloaded (and verified) in the "pause" state.

If blocks are in flight and the pause has been triggered, there is now a special info label Wait to finish current downloads.

paveljanik · 2017-04-20T09:10:24Z

Well, I have to change my previous opinion. I think this can be useful.

Concept ACK

Will test soon.

paveljanik · 2017-04-25T10:17:43Z

Needs rebase.

ryanofsky · 2017-05-01T18:35:50Z

ACK e952b67d294043d9758b37bf2be57a982b41c051

Code looks good. On the UI feature, two minor comments:

Pausing the download throws off "Estimated time left till synced." It would be better pausing didn't affect estimated time.
Pause/Resume button really sticks out where it's currently placed. Maybe it would make more sense next to the progress bar or near the hide button.

sipa · 2017-05-01T22:54:35Z

Needs rebase.

jonasschnelli · 2017-05-11T13:26:34Z

Rebased.

paveljanik · 2017-05-15T16:56:55Z

Testing this again.

ACK fc84323

I think this could be even more usable if it can be called once fully in sync with the network. But I can't display the overlay then...

laanwj · 2017-05-24T06:54:36Z

I think this could be even more usable if it can be called once fully in sync with the network. But I can't display the overlay then...

Hm I vaguely remember I added that functionality once, you should be able to bring up the overlay by the secret trick of clicking on the sync icon.

paveljanik · 2017-05-24T06:57:12Z

@laanwj But the sync icon (you mean the triangle with an exclamation mark inside?) is not displayed when you are "in sync" with the network.

jonasschnelli · 2017-05-24T06:57:48Z

I think this could be even more usable if it can be called once fully in sync with the network. But I can't display the overlay then...

There are four ways how the modal-overlay can be opened:
-> auto-opens when in IBD/sync
-> Click on the warning icons next to the balance
-> Click on the progress bar during IBD/sync
-> Click on the sync icon in the status bar

Though I agree with you, there is no option how to open it once you are in sync... which could be useful, but independent to this PR.

laanwj · 2017-05-24T07:03:31Z

@paveljanik Oh, though it also worked with the checkmark that takes its place.

DrahtBot · 2018-07-22T12:55:36Z

The last travis run for this pull request was 95 days ago and is thus outdated. To trigger a fresh travis build, this pull request should be closed and re-opened.

maflcko · 2018-07-22T19:20:03Z

src/qt/bitcoingui.cpp

could use the new connect syntax, so it wouldn't have to be changed again in the future?

DrahtBot · 2018-08-21T10:36:41Z

Needs rebase

jonasschnelli · 2018-10-17T19:37:34Z

Rebased.

practicalswift · 2018-10-19T06:33:33Z

src/qt/modaloverlay.cpp

+
+    // disable pause button when we can fetch directly
+    // avoid using the core-layer's existing CanFetchDirectly()
+    bool canFetchDirectly = (blockDate.toTime_t() > GetAdjustedTime() - Params().GetConsensus().nPowTargetSpacing * 20);


nit: Redundant parentheses :-)

fanquake · 2019-06-17T09:34:20Z

Discussion has dragged on and died out here. Going to label "Up for grabs" and close for now.

jonasschnelli added the GUI label Jan 10, 2017

jonasschnelli force-pushed the 2017/01/autodownload branch from 42882c6 to abf0941 Compare January 10, 2017 17:36

kallewoof reviewed Feb 28, 2017

View reviewed changes

laanwj added this to the 0.15.0 milestone Mar 14, 2017

jonasschnelli force-pushed the 2017/01/autodownload branch 2 times, most recently from dd9f365 to e2e86ec Compare March 17, 2017 14:54

laanwj reviewed Apr 19, 2017

View reviewed changes

jonasschnelli force-pushed the 2017/01/autodownload branch from e2e86ec to e952b67 Compare April 20, 2017 08:30

jonasschnelli force-pushed the 2017/01/autodownload branch from e952b67 to fc84323 Compare May 11, 2017 13:26

DrahtBot removed the Needs rebase label Jul 14, 2018

DrahtBot closed this Jul 22, 2018

DrahtBot reopened this Jul 22, 2018

DrahtBot mentioned this pull request Jul 22, 2018

Use new Qt5 connect syntax #13529

Merged

maflcko reviewed Jul 22, 2018

View reviewed changes

src/qt/bitcoingui.cpp Outdated

Copy link

Member

maflcko Jul 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could use the new connect syntax, so it wouldn't have to be changed again in the future?

laanwj modified the milestones: 0.17.0, 0.18.0 Jul 23, 2018

DrahtBot added the Needs rebase label Aug 21, 2018

jonasschnelli added 3 commits October 17, 2018 21:03

Add fAutoRequestBlocks to disabled/enable the verification progress

3a3f2b0

[Qt] update header-syncing progress when not processing a block

62ce306

[Qt] Add option to pause/resume block downloads

0e155d1

jonasschnelli force-pushed the 2017/01/autodownload branch from 2079551 to 318ad29 Compare October 17, 2018 19:37

jonasschnelli added 5 commits October 17, 2018 21:49

Rename autorequest blocks methods

c032740

Add setter/getter for fAutoRequestBlocks

5189ca4

Show blocks-in-flight

95686e9

Show special info when autodownload is disabled but blocks are in flight

53027a9

Disable "pause downloading blocks" when we can fetch blocks directly

718ceef

jonasschnelli force-pushed the 2017/01/autodownload branch from 318ad29 to 718ceef Compare October 17, 2018 19:50

practicalswift reviewed Oct 19, 2018

View reviewed changes

laanwj removed this from the 0.18.0 milestone Feb 6, 2019

fanquake added the Up for grabs label Jun 17, 2019

fanquake closed this Jun 17, 2019

laanwj removed the Needs rebase label Oct 24, 2019

MarkLTZ added a commit to litecoinz-core/litecoinz that referenced this pull request Nov 17, 2019

[gui] Add option to pause/resume blocks download (bitcoin#9502)

6293e78

bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021

fanquake removed the Up for grabs label Aug 4, 2022

[Qt] Add option to pause/resume block downloads #9502

[Qt] Add option to pause/resume block downloads #9502

Uh oh!

Conversation

jonasschnelli commented Jan 10, 2017 • edited by DrahtBot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

paveljanik commented Jan 10, 2017

Uh oh!

jonasschnelli commented Jan 10, 2017

Uh oh!

luke-jr commented Jan 10, 2017

Uh oh!

maflcko commented Jan 10, 2017 via email

Uh oh!

luke-jr commented Jan 10, 2017

Uh oh!

jonasschnelli commented Jan 10, 2017

Uh oh!

kallewoof left a comment

Choose a reason for hiding this comment

Uh oh!

kallewoof Feb 28, 2017

Choose a reason for hiding this comment

Uh oh!

kallewoof Feb 28, 2017

Choose a reason for hiding this comment

Uh oh!

laanwj commented Mar 14, 2017

Uh oh!

jonasschnelli commented Mar 17, 2017

Uh oh!

laanwj Apr 19, 2017

Choose a reason for hiding this comment

Uh oh!

jonasschnelli Apr 19, 2017

Choose a reason for hiding this comment

Uh oh!

laanwj Apr 19, 2017

Choose a reason for hiding this comment

Uh oh!

laanwj commented Apr 19, 2017

Uh oh!

jonasschnelli commented Apr 20, 2017

Uh oh!

paveljanik commented Apr 20, 2017

Uh oh!

paveljanik commented Apr 25, 2017

Uh oh!

ryanofsky commented May 1, 2017

Uh oh!

sipa commented May 1, 2017

Uh oh!

jonasschnelli commented May 11, 2017

Uh oh!

paveljanik commented May 15, 2017

Uh oh!

laanwj commented May 24, 2017

Uh oh!

paveljanik commented May 24, 2017

Uh oh!

jonasschnelli commented May 24, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laanwj commented May 24, 2017

Uh oh!

DrahtBot commented Jul 22, 2018

Uh oh!

maflcko Jul 22, 2018

Choose a reason for hiding this comment

Uh oh!

DrahtBot commented Aug 21, 2018

Uh oh!

jonasschnelli commented Oct 17, 2018

Uh oh!

practicalswift Oct 19, 2018

Choose a reason for hiding this comment

Uh oh!

fanquake commented Jun 17, 2019

Uh oh!

jonasschnelli commented Jan 10, 2017 •

edited by DrahtBot

Loading

jonasschnelli commented May 24, 2017 •

edited

Loading