[refactor] Remove using namespace <xxx> from rpc/ & script/ sources #9476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This might conflict with pending rpc and multiwallet changes, which are planned for 0.14. Imo, we should wait until feature freeze in two weeks and then do the same-binary check on this pull and merge into 0.14 if it passes. |
Contributor
Author
|
@MarcoFalke OK. |
kallewoof
changed the title
kallewoof
force-pushed
the
no-using-namespace-rpc-script
branch
2 times, most recently
from
0ae5238 to
6947651
Compare
Member
|
Feature freeze is here. Please rebase this. |
kallewoof
force-pushed
the
no-using-namespace-rpc-script
branch
from
6947651 to
1eb9d53
Compare
Contributor
Author
Contributor
|
utACK 1eb9d53 |
dcousens
approved these changes
Feb 24, 2017
Member
|
utACK 1eb9d53 |
Member
|
utACK |
Member
|
Needs another rebase, sorry. |
kallewoof
force-pushed
the
no-using-namespace-rpc-script
branch
from
1eb9d53 to
8cbfc4e
Compare
Contributor
Author
kallewoof
force-pushed
the
no-using-namespace-rpc-script
branch
from
cd5971c to
8cbfc4e
Compare
Contributor
Author
|
I'm not sure why Travis is failing. Edit: It stopped failing. |
kallewoof
force-pushed
the
no-using-namespace-rpc-script
branch
from
8d51012 to
8cbfc4e
Compare
laanwj
added a commit
that referenced
this pull request
Mar 9, 2017
…pt/ sources 8cbfc4e Refactor: Remove using namespace <xxx> from script/ (Karl-Johan Alm) f3c264e Refactor: Remove using namespace <xxx> from rpc/ (Karl-Johan Alm) Tree-SHA512: 407e80eeda0b8e1df22c5fcba33572e117542fde83c67357f6c2d98fa60bcc7b21bb88ad9a1ee59062fbec17fadaa4836b69e8e6d18188b4027b794357634467
ghost
mentioned this pull request
ghost
mentioned this pull request
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Feb 21, 2018
… & script/ sources 8cbfc4e Refactor: Remove using namespace <xxx> from script/ (Karl-Johan Alm) f3c264e Refactor: Remove using namespace <xxx> from rpc/ (Karl-Johan Alm) Tree-SHA512: 407e80eeda0b8e1df22c5fcba33572e117542fde83c67357f6c2d98fa60bcc7b21bb88ad9a1ee59062fbec17fadaa4836b69e8e6d18188b4027b794357634467
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
… & script/ sources 8cbfc4e Refactor: Remove using namespace <xxx> from script/ (Karl-Johan Alm) f3c264e Refactor: Remove using namespace <xxx> from rpc/ (Karl-Johan Alm) Tree-SHA512: 407e80eeda0b8e1df22c5fcba33572e117542fde83c67357f6c2d98fa60bcc7b21bb88ad9a1ee59062fbec17fadaa4836b69e8e6d18188b4027b794357634467
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sub-set of #9235, including only the
rpcandscriptdirs.Same-binaries check (2017-03-08):
The affected files and namespaces: