Skip to content

Update the Windows build notes #9433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maflcko merged 1 commit into from
Jan 1, 2017
Merged

Update the Windows build notes #9433

maflcko merged 1 commit into from
Jan 1, 2017

Conversation

@droark
Copy link
Contributor

@droark droark commented Dec 27, 2016 •
edited
Loading

  • Clarify the Windows Subsystem For Linux section.
  • Clarify the build requirements.

@fanquake
Copy link
Member

fanquake commented Dec 27, 2016 •
edited
Loading

Looks ok. utACK 1f30bc3

jonasschnelli
jonasschnelli reviewed Dec 27, 2016
View reviewed changes
doc/build-windows.md Outdated
Copy link
Contributor

@jonasschnelli jonasschnelli Dec 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: not sure if we should set the jobs amount in the documentation. IMO we also don't do that for other build docs. It depends on available RAM/cores.

Copy link
Member

@sipa sipa Dec 27, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're going to add -j in places, at least explain that it impacts parallellism in a comment.

@droark
Copy link
Contributor Author

droark commented Dec 27, 2016

Removed the -j flags (my own and the ones that were present) and did a fixup/reword. @jonasschnelli and @sipa brought up good points regarding parallelism. Doing a parallel make on the depends portion caused several errors on my system. I was able to keep trying and get it to work but it wasn't ideal.

Update the Windows build notes
b705a04 
- Clarify the Windows Subsystem For Linux section.
- Clarify the build requirements.
@droark
Copy link
Contributor Author

droark commented Jan 1, 2017

Also, just to clarify, I did successfully build and run the 32-bit version. make check passed too.

@maflcko
Copy link
Member

maflcko commented Jan 1, 2017

ACK b705a04

@maflcko maflcko merged commit b705a04 into bitcoin:master Jan 1, 2017
maflcko pushed a commit that referenced this pull request Jan 1, 2017
Merge #9433: Update the Windows build notes
caa2f10 
b705a04 Update the Windows build notes (Douglas Roark)
codablock pushed a commit to codablock/dash that referenced this pull request Jan 18, 2018
@codablock
Merge bitcoin#9433: Update the Windows build notes
b584f56 
b705a04 Update the Windows build notes (Douglas Roark)
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
@andvgal
Merge bitcoin#9433: Update the Windows build notes
cfd44d0 
b705a04 Update the Windows build notes (Douglas Roark)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sipa sipa sipa left review comments

+1 more reviewer

@jonasschnelli jonasschnelli jonasschnelli left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Docs Windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@droark @fanquake @maflcko @jonasschnelli @sipa