build: Fix 'make deploy' for OSX #9412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Native OSX uses system tools rather than 3rd party dependencies. rsvg-convert is still required, though.
jonasschnelli
force-pushed
the
2016/12/fix_mac_deploy
branch
from
3d272fb to
b01667c
Compare
Member
|
Quickly tested (10.11), finished .dmg seems to work ok. Good idea with a note in the build doc, otherwise the Only thing I noticed were these files left in the dir afterwards, however that might have always been the case: Build log: This will supersede #9405 |
Member
|
Concept ACK |
Contributor
|
ACK on make deploy, but apparently I need OS X 10.12 or later (I have 10.11.6) so I can't actually test it. (Is there some reason for that requirement at all?) |
Contributor
Author
|
@kallewoof: why would you need macOS 10.12? I think this should work also on OSX 10.8 and should also work on OSX 10.11. |
Member
|
You shouldn't need 10.12, I'm testing on 10.11 .
…On Fri, 23 Dec 2016 at 20:58, kallewoof ***@***.***> wrote:
ACK on make deploy, but apparently I need OS X 10.12 or later (I have
10.11.6) so I can't actually test it. (Is there some reason for that
requirement at all?)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#9412 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA0t8uGDU5yuCBRzHQWnXkZGJTDxqSgjks5rK8VqgaJpZM4LUqbc>
.
|
Contributor
|
Weird. I didn't change anything I just fetched the 2016/12/fix_mac_deploy branch and did make, make deploy and grabbed the resulting Bitcoin-Qt.dmg file. Edited: For reference: Edited 2: Probably obvious, but |
Member
|
There was a bugfix included in #9405, 77c4570, @jonasschnelli did you want to cherry pick/include that here? |
Contributor
Author
|
Added 77c4570 from #9405. |
Member
|
Retested on OSX 10.12. The finished .dmg mounts correctly and the Bitcoin Core.app inside runs fine. ACK 2fb98f6. |
Contributor
|
I am not sure why my specific machine (10.11.6) does this but the problem I am seeing appears to stem from a lack of the diff --git a/configure.ac b/configure.ac
index 74808cd33..9d7109314 100644
--- a/configure.ac
+++ b/configure.ac
@@ -308,6 +308,9 @@ case $host in
LEVELDB_TARGET_FLAGS="-DOS_MACOSX"
if test x$cross_compiling != xyes; then
BUILD_OS=darwin
+ CPPFLAGS="$CPPFLAGS -mmacosx-version-min=10.9"
+ CXXFLAGS="$CXXFLAGS -mmacosx-version-min=10.9"
+ LIBS="$LIBS -mmacosx-version-min=10.9"
AC_CHECK_PROG([PORT],port, port)
if test x$PORT = xport; then
dnl add default macports pathsAbove patch fixes the issue on my end. Note that a [1]: Univalue emits e.g. Edit: |
jonasschnelli
added a commit
that referenced
this pull request
Jan 2, 2017
Contributor
|
Hello. FYI, the mount looks a little weird on my system (10.12.2) when built with I don't have this problem with the official 0.13.2 RC1 DMG, which is correctly sized (while also showing .background, although that might just be my setup). Other than that, this works fine, and the actual code itself looks fine to me. |
Member
If you need a dmg for testing from current master (with this pull included) you can download https://bitcoin.jonasschnelli.ch/nightlybuilds/2017-01-03/bitcoin-0.13.99-osx-unsigned.dmg in about 3 hours. |
Contributor
|
@MarcoFalke - The nightly build looks fine to me. Not sure why mine came out a bit weird. Any idea on where I might be able to look and investigate? Thanks. |
Contributor
Author
|
@droark: the make deploy process on OSX is different to the linux based (gitian) make deploy. It uses different tools. The |
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly work from @theuni.
This fix works on my macOS 10.12.
Native OSX uses system tools rather than 3rd party dependencies. rsvg-convert
is still required, though.
Should fix #8120