Make rpcauth help message clearer, add example in example .conf #9401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instagibbs
commented
Dec 22, 2016
| #rpcbind=<addr> | ||
|
|
||
| # You must set rpcuser and rpcpassword to secure the JSON-RPC api | ||
| # If no rpcpassword is set, rpc cookie auth is sought. The default `-rpccookiefile` name |
Member
Author
There was a problem hiding this comment.
Note: cookie is only created if -server=1
Member
There was a problem hiding this comment.
Do you imagine any reason why it would be otherwise?
Member
Author
There was a problem hiding this comment.
No, but more than one user was apparently confused by this!(getting feedback offline) Maybe it's too obvious.
maflcko
reviewed
Jan 4, 2017
| strUsage += HelpMessageOpt("-rpcuser=<user>", _("Username for JSON-RPC connections")); | ||
| strUsage += HelpMessageOpt("-rpcpassword=<pw>", _("Password for JSON-RPC connections")); | ||
| strUsage += HelpMessageOpt("-rpcauth=<userpw>", _("Username and hashed password for JSON-RPC connections. The field <userpw> comes in the format: <USERNAME>:<SALT>$<HASH>. A canonical python script is included in share/rpcuser. This option can be specified multiple times")); | ||
| strUsage += HelpMessageOpt("-rpcauth=<userpw>", _("Username and hashed password for JSON-RPC connections. The field <userpw> comes in the format: <USERNAME>:<SALT>$<HASH>. A canonical python script is included in share/rpcuser. The client then connects normally using the rpcuser=<USERNAME>/rpcpassword=<PASSWORD> pair of arguments. This option can be specified multiple times")); |
Member
There was a problem hiding this comment.
Could make sense to split the translation string into smaller logical chunks while touching?
Member
|
ACK 0513c70 |
maflcko
pushed a commit
that referenced
this pull request
Jan 4, 2017
…e .conf 0513c70 Make rpcauth help message clearer, add example in example .conf (Gregory Sanders)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 18, 2018
… example .conf 0513c70 Make rpcauth help message clearer, add example in example .conf (Gregory Sanders)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
… example .conf 0513c70 Make rpcauth help message clearer, add example in example .conf (Gregory Sanders)
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 26, 2019
… example .conf 0513c70 Make rpcauth help message clearer, add example in example .conf (Gregory Sanders)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users are confused about the interplay of the three different ways of authenticating rpc requests. This is meant to give extra clarity.