Remove unused test files and references #9376

btcdrak · 2016-12-19T07:45:18Z

laanwj · 2016-12-19T09:00:04Z

This must have broken make distdir. Unsure how did it pass the Travis tests.

utACK 23208ac: verified that test/data/blanktx.hex is indeed gone and should not be referenced, and that test/data/txcreatesign.json is unreferenced and can go.

fanquake · 2016-12-20T10:36:30Z

@laanwj Yes it looks like make distdir has been broken.

$ make distdir
if test -d "bitcoin-0.13.99"; then find "bitcoin-0.13.99" -type d ! -perm -200 -exec chmod u+w {} ';' && rm -rf "bitcoin-0.13.99" || { sleep 5 && rm -rf "bitcoin-0.13.99"; }; else :; fi
test -d "bitcoin-0.13.99" || mkdir "bitcoin-0.13.99"
 (cd src && /Applications/Xcode.app/Contents/Developer/usr/bin/make  top_distdir=../bitcoin-0.13.99 distdir=../bitcoin-0.13.99/src \
     am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
Generated bench/data/block413567.raw.h
Generated test/data/tx_valid.json.h
make[1]: *** No rule to make target `test/data/blanktx.hex', needed by `distdir'.  Stop.
make: *** [distdir] Error 1

However after merging this I still see:

config.status: executing depfiles commands
make[1]: *** No rule to make target `test/data/txcreatesign.hex', needed by `distdir'.  Stop.
make: *** [distdir] Error 1

@btcdrak Could you fixup that reference? Looks like it's now txcreatesignv1.hex?

laanwj · 2016-12-20T12:47:39Z

@theuni Shouldn't Travis pick up problems like this? It always did for me, although now that I think of it that was when forgetting to specify .h files.

maflcko · 2016-12-20T13:06:17Z

@laanwj Travis never does the distdir step, I think.

…

On Tue, Dec 20, 2016 at 1:47 PM, Wladimir J. van der Laan < ***@***.***> wrote: @theuni <https://github.com/theuni> Shouldn't Travis pick up problems like this? It always did for me, although now that I think of it that was when forgetting to specify .h files. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#9376 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGGmv62Fyb17XHp0q4b6toRWo4VrPGxSks5rJ855gaJpZM4LQc6h> .

laanwj · 2016-12-20T14:22:53Z

Okay, then I must be confused with gitian. I thought it did that before building. But maybe that's only gitian.

ghost · 2016-12-20T16:10:22Z

I got this error

+ make dist
make  dist-gzip am__post_remove_distdir='@:'
make[1]: Entering directory `/home/ubuntu/build/bitcoin'
if test -d "bitcoin-0.13.99"; then find "bitcoin-0.13.99" -type d ! -perm -200 -                     exec chmod u+w {} ';' && rm -rf "bitcoin-0.13.99" || { sleep 5 && rm -rf "bitcoi                     n-0.13.99"; }; else :; fi
test -d "bitcoin-0.13.99" || mkdir "bitcoin-0.13.99"
 (cd src && make  top_distdir=../bitcoin-0.13.99 distdir=../bitcoin-0.13.99/src                      \
     am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[2]: Entering directory `/home/ubuntu/build/bitcoin/src'
Generated bench/data/block413567.raw.h
Generated test/data/script_tests.json.h
Generated test/data/base58_keys_valid.json.h
Generated test/data/base58_encode_decode.json.h
Generated test/data/base58_keys_invalid.json.h
Generated test/data/tx_invalid.json.h
Generated test/data/tx_valid.json.h
Generated test/data/sighash.json.h
make[2]: *** No rule to make target `test/data/blanktx.hex', needed by `distdir'                     .  Stop.
make[2]: Leaving directory `/home/ubuntu/build/bitcoin/src'
make[1]: *** [distdir] Error 1
make[1]: Leaving directory `/home/ubuntu/build/bitcoin'
make: *** [dist] Error 2

theuni · 2016-12-20T18:07:59Z

@laanwj IIRC we used to have a distcheck in Travis, but got rid of it a while ago because it was too heavy. Or maybe it was that it used distdir before the out-of-tree build?

I think we could probably add back the lighter make distdir at the end to catch these things.

btcdrak · 2016-12-20T19:50:31Z

Could you fixup that reference? Looks like it's now txcreatesignv1.hex?

@fanquake done.

fanquake · 2016-12-20T23:37:34Z

@btcdrak Thanks, looks better now:

bash-3.2$ make distdir
if test -d "bitcoin-0.13.99"; then find "bitcoin-0.13.99" -type d ! -perm -200 -exec chmod u+w {} ';' && rm -rf "bitcoin-0.13.99" || { sleep 5 && rm -rf "bitcoin-0.13.99"; }; else :; fi
test -d "bitcoin-0.13.99" || mkdir "bitcoin-0.13.99"
 (cd src && /Applications/Xcode.app/Contents/Developer/usr/bin/make  top_distdir=../bitcoin-0.13.99 distdir=../bitcoin-0.13.99/src \
     am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
 (cd secp256k1 && /Applications/Xcode.app/Contents/Developer/usr/bin/make  top_distdir=../../bitcoin-0.13.99 distdir=../../bitcoin-0.13.99/src/secp256k1 \
     am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
:
test -d "../../bitcoin-0.13.99/src/secp256k1" || mkdir "../../bitcoin-0.13.99/src/secp256k1"
test -n ":" \
	|| find "../../bitcoin-0.13.99/src/secp256k1" -type d ! -perm -755 \
		-exec chmod u+rwx,go+rx {} \; -o \
	  ! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
	  ! -type d ! -perm -400 -exec chmod a+r {} \; -o \
	  ! -type d ! -perm -444 -exec /bin/sh /Users/michael/bitcoin/src/secp256k1/build-aux/install-sh -c -m a+r {} {} \; \
	|| chmod -R a+r "../../bitcoin-0.13.99/src/secp256k1"
 (cd univalue && /Applications/Xcode.app/Contents/Developer/usr/bin/make  top_distdir=../../bitcoin-0.13.99 distdir=../../bitcoin-0.13.99/src/univalue \
     am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
:
test -d "../../bitcoin-0.13.99/src/univalue" || mkdir "../../bitcoin-0.13.99/src/univalue"
test -n ":" \
	|| find "../../bitcoin-0.13.99/src/univalue" -type d ! -perm -755 \
		-exec chmod u+rwx,go+rx {} \; -o \
	  ! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
	  ! -type d ! -perm -400 -exec chmod a+r {} \; -o \
	  ! -type d ! -perm -444 -exec /bin/sh /Users/michael/bitcoin/src/univalue/build-aux/install-sh -c -m a+r {} {} \; \
	|| chmod -R a+r "../../bitcoin-0.13.99/src/univalue"
 (cd doc/man && /Applications/Xcode.app/Contents/Developer/usr/bin/make  top_distdir=../../bitcoin-0.13.99 distdir=../../bitcoin-0.13.99/doc/man \
     am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
/Applications/Xcode.app/Contents/Developer/usr/bin/make  \
	  top_distdir="bitcoin-0.13.99" distdir="bitcoin-0.13.99" \
	  dist-hook
/usr/local/bin/git archive --format=tar HEAD -- src/clientversion.cpp | ${TAR-tar} -C bitcoin-0.13.99 -xf -
test -n "" \
	|| find "bitcoin-0.13.99" -type d ! -perm -755 \
		-exec chmod u+rwx,go+rx {} \; -o \
	  ! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
	  ! -type d ! -perm -400 -exec chmod a+r {} \; -o \
	  ! -type d ! -perm -444 -exec /bin/sh /Users/michael/bitcoin/build-aux/install-sh -c -m a+r {} {} \; \
	|| chmod -R a+r "bitcoin-0.13.99"

ACK 9cb6624

laanwj · 2016-12-21T08:03:59Z

@laanwj IIRC we used to have a distcheck in Travis, but got rid of it a while ago because it was too heavy. Or maybe it was that it used distdir before the out-of-tree build?

The travis check was the only way most people were even noticing inconsistencies in the Makefile with regard to installed files, this is why pulls like this are popping up all over the place now.

It would be fine even if only one Travis builder built from distdir.

9cb6624 Fix testfile reference (BtcDrak) 23208ac Remove unused test files and references (BtcDrak)

droark · 2016-12-21T18:51:01Z

Posthumous ACK

blanktx.json is still sitting around unused. I believe it can be used for a v1 JSON test that doesn't seem to exist right now. I'll file a PR where I change it to blanktxv1.json and integrate it into the test suite.

9cb6624 Fix testfile reference (BtcDrak) 23208ac Remove unused test files and references (BtcDrak)

Remove unused test files and references

23208ac

fanquake added the Tests label Dec 19, 2016

btcdrak mentioned this pull request Dec 19, 2016

Bump transaction version default to 2 #7562

Merged

Fix testfile reference

9cb6624

fanquake mentioned this pull request Dec 20, 2016

travis: make distdir #9390

Merged

laanwj mentioned this pull request Dec 21, 2016

build: Include cuckoocache header in Makefile #9393

Merged

laanwj merged commit 9cb6624 into bitcoin:master Dec 21, 2016

laanwj added a commit that referenced this pull request Dec 21, 2016

Merge #9376: Remove unused test files and references

8dfe9fc

9cb6624 Fix testfile reference (BtcDrak) 23208ac Remove unused test files and references (BtcDrak)

laanwj mentioned this pull request Dec 21, 2016

CentOS Test Failures #9394

Closed

btcdrak deleted the fixmissing branch December 21, 2016 21:22

droark mentioned this pull request Dec 21, 2016

Re-enable a blank v1 Tx JSON test #9406

Merged

codablock pushed a commit to codablock/dash that referenced this pull request Jan 20, 2018

Merge bitcoin#9376: Remove unused test files and references

b72f924

9cb6624 Fix testfile reference (BtcDrak) 23208ac Remove unused test files and references (BtcDrak)

dagurval mentioned this pull request Apr 27, 2018

Bump transaction version default to 2 bitcoinxt/bitcoinxt#405

Merged

andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019

Merge bitcoin#9376: Remove unused test files and references

fb97344

9cb6624 Fix testfile reference (BtcDrak) 23208ac Remove unused test files and references (BtcDrak)

CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Feb 27, 2019

Merge bitcoin#9376: Remove unused test files and references

4440487

9cb6624 Fix testfile reference (BtcDrak) 23208ac Remove unused test files and references (BtcDrak)

bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove unused test files and references #9376

Remove unused test files and references #9376

Uh oh!

btcdrak commented Dec 19, 2016

Uh oh!

laanwj commented Dec 19, 2016 •

edited

Loading

Uh oh!

fanquake commented Dec 20, 2016

Uh oh!

laanwj commented Dec 20, 2016

Uh oh!

maflcko commented Dec 20, 2016 via email

Uh oh!

laanwj commented Dec 20, 2016

Uh oh!

ghost commented Dec 20, 2016 •

edited by ghost

Loading

Uh oh!

theuni commented Dec 20, 2016

Uh oh!

btcdrak commented Dec 20, 2016

Uh oh!

fanquake commented Dec 20, 2016

Uh oh!

laanwj commented Dec 21, 2016 •

edited

Loading

Uh oh!

droark commented Dec 21, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Remove unused test files and references #9376

Remove unused test files and references #9376

Uh oh!

Conversation

btcdrak commented Dec 19, 2016

Uh oh!

laanwj commented Dec 19, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fanquake commented Dec 20, 2016

Uh oh!

laanwj commented Dec 20, 2016

Uh oh!

maflcko commented Dec 20, 2016 via email

Uh oh!

laanwj commented Dec 20, 2016

Uh oh!

ghost commented Dec 20, 2016 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

theuni commented Dec 20, 2016

Uh oh!

btcdrak commented Dec 20, 2016

Uh oh!

fanquake commented Dec 20, 2016

Uh oh!

laanwj commented Dec 21, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

droark commented Dec 21, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

laanwj commented Dec 19, 2016 •

edited

Loading

ghost commented Dec 20, 2016 •

edited by ghost

Loading

laanwj commented Dec 21, 2016 •

edited

Loading