[qa] Add test for rescan feature of wallet key import RPCs #9331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Covers importaddress, importpubkey, importprivkey, and importmulti RPCs.
ryanofsky
force-pushed
the
pr/test-import-rescan
branch
from
6bbbe2c to
7e1d6fd
Compare
maflcko
approved these changes
Dec 15, 2016
qa/rpc-tests/import-rescan.py
Outdated
Member
There was a problem hiding this comment.
from decimal import Decimalwould be cleaner
qa/rpc-tests/import-rescan.py
Outdated
Member
There was a problem hiding this comment.
You don't have to be too strict about not exceeding 80 chars. I think 120 is preferred, but there does not seem to be a strict rule, so meh.
Contributor
Author
There was a problem hiding this comment.
Thanks, I was just using yapf, but I increased the column width.
qa/rpc-tests/import-rescan.py
Outdated
Member
There was a problem hiding this comment.
This probably does not change during the loop, so maybe cache it?
qa/rpc-tests/import-rescan.py
Outdated
Member
There was a problem hiding this comment.
Assert that the transaction pool is empty, after each generate?
ryanofsky
force-pushed
the
pr/test-import-rescan
branch
from
7e1d6fd to
d8c0b9f
Compare
Member
|
Thanks, LGTM |
laanwj
added a commit
that referenced
this pull request
Dec 15, 2016
d8c0b9f [qa] Add test for rescan feature of wallet key import RPCs (Russell Yanofsky)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 18, 2018
…port RPCs d8c0b9f [qa] Add test for rescan feature of wallet key import RPCs (Russell Yanofsky)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
…port RPCs d8c0b9f [qa] Add test for rescan feature of wallet key import RPCs (Russell Yanofsky)
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 26, 2019
…port RPCs d8c0b9f [qa] Add test for rescan feature of wallet key import RPCs (Russell Yanofsky)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test only change.
New test covers importaddress, importpubkey, importprivkey, and importmulti RPC's.
This was originally part of #9137, but I split it off because the test is useful on its own.