Skip to content

Conversation

@gmaxwell
Copy link
Contributor

This avoids a compile failure on newly installed debian stretch systems.

This avoids a compile failure on newly installed debian stretch systems.
@gmaxwell
Copy link
Contributor Author

Needs backport tag please.

@jonasschnelli
Copy link
Contributor

Thanks for the fix!
utACK bae1eef

@jonasschnelli
Copy link
Contributor

Maybe we should also include the required changes in qt/paymentrequestplus.cpp to this PR?

@gmaxwell gmaxwell changed the title Fix wallet/test/crypto_tests.cpp for OpenSSL 1.1 API. Update for OpenSSL 1.1 API. Dec 12, 2016
@gmaxwell
Copy link
Contributor Author

gmaxwell commented Dec 12, 2016

@jonasschnelli Thanks, I hadn't noticed that the stretch system I was testing on had decided to compile without the GUI, and so it wasn't getting the error there.

@sipa
Copy link
Member

sipa commented Dec 12, 2016

utACK 9285b9a4899e7af56777e79a308f6335837d350d

This avoids a compile failure on newly installed debian stretch systems.
@gmaxwell
Copy link
Contributor Author

@sipa @jonasschnelli reACK after changes to qt/paymentrequestplus?

Copy link
Contributor

@jonasschnelli jonasschnelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK b05b1af

@maflcko maflcko added Refactoring and removed Tests labels Dec 13, 2016
@laanwj laanwj merged commit b05b1af into bitcoin:master Dec 13, 2016
laanwj added a commit that referenced this pull request Dec 13, 2016
b05b1af Fix qt/paymentrequestplus.cpp for OpenSSL 1.1 API. (Gregory Maxwell)
bae1eef Fix wallet/test/crypto_tests.cpp for OpenSSL 1.1 API. (Gregory Maxwell)
@maflcko maflcko added this to the 0.13.2 milestone Dec 14, 2016
@maflcko
Copy link
Member

maflcko commented Dec 14, 2016

Backport in #9347

maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Dec 14, 2016
@sipa
Copy link
Member

sipa commented May 30, 2017

Interesting... does this actually work on OpenSSL 1.1? The documentation says that EVP_CIPHER_CTX_cleanup was removed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants