[wallet] Disable free transactions when relay is disabled #9316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
utACK |
Member
|
utACK faf4ca8 |
Contributor
|
ACK faf4ca8 |
laanwj
added a commit
that referenced
this pull request
Dec 20, 2016
faf4ca8 [wallet] Disable free transactions when relay is disabled (MarcoFalke)
Member
|
utACK faf4ca8 |
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 18, 2018
…disabled faf4ca8 [wallet] Disable free transactions when relay is disabled (MarcoFalke)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
…disabled faf4ca8 [wallet] Disable free transactions when relay is disabled (MarcoFalke)
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 26, 2019
…disabled faf4ca8 [wallet] Disable free transactions when relay is disabled (MarcoFalke)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creation of free transactions with their relay disabled was never supported, but with the relay disabled by default an InitError could make sense.
The (probably cleaner) alternative in light of the removal planned for 0.15 would be to just get rid of
fSendFreeTransactionsalready now... No strong opinion for one or the other.