Assert FRESH validity in CCoinsViewCache::BatchWrite #9310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanofsky
force-pushed
the
pr/coins-batch-assert
branch
3 times, most recently
from
02e6924 to
376d435
Compare
Member
|
Travis is failing on Windows |
ryanofsky
force-pushed
the
pr/coins-batch-assert
branch
2 times, most recently
from
c3ba2d3 to
3d742a0
Compare
ryanofsky
force-pushed
the
pr/coins-batch-assert
branch
from
3d742a0 to
ac10e17
Compare
ryanofsky
changed the title
Contributor
Author
|
Switched from |
Member
|
utACK ac10e17 |
ryanofsky
force-pushed
the
pr/coins-batch-assert
branch
from
ac10e17 to
dd44ea3
Compare
Contributor
Author
|
Rebased to avoid merge conflict (in ccoins_test) with #9107. |
Contributor
|
utACK dd44ea3 |
Contributor
|
utACK dd44ea3 (didn't look too hard at tests, though). |
sipa
added a commit
that referenced
this pull request
Jan 9, 2017
dd44ea3 Check FRESH validity in CCoinsViewCache::BatchWrite (Russell Yanofsky)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Oct 23, 2017
dd44ea3 Check FRESH validity in CCoinsViewCache::BatchWrite (Russell Yanofsky)
ghost
mentioned this pull request
random-zebra
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Aug 18, 2020
cdbb1a6 Remove unused variable in test, fixing warning. (Russell Yanofsky) 03031a5 Check FRESH validity in CCoinsViewCache::BatchWrite (Russell Yanofsky) 3fb3e03 Fix dangerous condition in ModifyNewCoins. (random-zebra) 228d6bc [test] Add CCoinsViewCache Access/Modify/Write tests (random-zebra) Pull request description: Going on with the coins view cache update work (started with #1774 and #1777). This backports the following upstream PRs (adapting them with the assumption that duplicate coinbase transactions are not possible): - bitcoin#9308 - [test] Add CCoinsViewCache Access/Modify/Write tests - bitcoin#9107 - Safer modify new coins - bitcoin#9310 - Assert FRESH validity in CCoinsViewCache::BatchWrite - bitcoin#9435 - Removed unused variable in test, fixing warning. Note: Will rebase #1773 on top of this one (to change `ApplyTxInUndo` return value in the unit test too). ACKs for top commit: furszy: pretty nice one, ACK cdbb1a6 Fuzzbawls: ACK cdbb1a6 Tree-SHA512: 69c534da1083c3c4a535923e98da7750474c6698bb45e042778b539a27fab0455d78aaf670bed9485522f9d2ee25e4ad57fa7d35632523fe7376fe5f5febb1e5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a check for the validity of the FRESH flag in
CCoinsViewCache::BatchWrite. The check added here is analogous to the assert @morcos is adding in #9107. It is checking the same condition, just inside a different method (BatchWriteinstead ofModifyNewCoins).