Skip to content

Conversation

@TheBlueMatt
Copy link
Contributor

Pulled this out of #9243 because it is a logically separate change.

@sipa
Copy link
Member

sipa commented Dec 1, 2016

utACK 9e1f468

@laanwj
Copy link
Member

laanwj commented Dec 1, 2016

utACK 9e1f468

@paveljanik
Copy link
Contributor

paveljanik commented Dec 1, 2016

What is returned by mapMultiArgs.at("-bind").size() if !mapMultiArgs.count("-bind")? Do we need the condition at all?
Edit: answering to myself: std::out_of_range exception is thrown.

@sipa
Copy link
Member

sipa commented Dec 1, 2016

@paveljanik It would raise an exception. Using [] instead would result in adding "-bind" as a key to the map.

@paveljanik
Copy link
Contributor

ACK 9e1f468

@jonasschnelli
Copy link
Contributor

utACK 9e1f468

@gmaxwell
Copy link
Contributor

gmaxwell commented Dec 1, 2016

utACK

@instagibbs
Copy link
Member

utACK 9e1f468

@morcos
Copy link
Contributor

morcos commented Dec 1, 2016

utACK

@laanwj ready for merge

@sipa sipa merged commit 9e1f468 into bitcoin:master Dec 1, 2016
sipa added a commit that referenced this pull request Dec 1, 2016
9e1f468 Fix calculation of number of bound sockets to use (Matt Corallo)
luke-jr pushed a commit to luke-jr/bitcoin that referenced this pull request Dec 2, 2016
@laanwj laanwj added the P2P label Dec 19, 2016
codablock pushed a commit to codablock/dash that referenced this pull request Jan 17, 2018
9e1f468 Fix calculation of number of bound sockets to use (Matt Corallo)
lateminer pushed a commit to lateminer/bitcoin that referenced this pull request Oct 24, 2018
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
9e1f468 Fix calculation of number of bound sockets to use (Matt Corallo)
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Feb 25, 2019
9e1f468 Fix calculation of number of bound sockets to use (Matt Corallo)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants