Fix races for strMiscWarning and fLargeWork*Found, make QT runawayException use GetWarnings #9236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I have not yet tested the QT part of this change. |
Contributor
|
General Concept ACK but I would prefer moving the warning function in a new file (seems to be a misuse of utils.h/c). |
Member
|
Maybe `ui_interface.*` for `GetWarnings()`?
|
Contributor
Author
|
@MarcoFalke Can you walk me through your reason for adding a third warning context there? |
Contributor
|
utACK 6ed742dcbeeb16e7e5fcc42b292bc0c43f5e219c |
paveljanik
reviewed
Nov 30, 2016
src/warnings.cpp
Outdated
Contributor
There was a problem hiding this comment.
No RPC info about pre-release build? (I know you only copied this from prev. location.)
Contributor
Author
There was a problem hiding this comment.
strStatusBar does that, RPC is what you get in safemode errors, effectively.
Member
|
My initial thinking was to put all such ui related code into |
maflcko
reviewed
Nov 30, 2016
src/main.cpp
Outdated
Member
There was a problem hiding this comment.
Maybe std::string to preempt silent merge conflicts?
Member
|
Needs rebase. |
1 similar comment
Member
|
Needs rebase. |
Contributor
Author
|
I believe I addressed the comments from @MarcoFalke |
Member
|
utACK 0b5a146cbc04949a8eb2a3f07e53c768fb0ca7dd |
…strMiscWarning. This is a first step in avoiding racy accesses to strMiscWarning. The change required moving GetWarnings and related globals to util.
This moves all access to these datastructures through accessor functions and protects them with a lock.
Contributor
Author
|
Rebased for the main murder mania. |
Member
|
Makes sense. utACK 749be01 |
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 18, 2018
…, make QT runawayException use GetWarnings 749be01 Move GetWarnings() into its own file. (Gregory Maxwell) e3ba0ef Eliminate data races for strMiscWarning and fLargeWork*Found. (Gregory Maxwell) c63198f Make QT runawayException call GetWarnings instead of directly access strMiscWarning. (Gregory Maxwell)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
…, make QT runawayException use GetWarnings 749be01 Move GetWarnings() into its own file. (Gregory Maxwell) e3ba0ef Eliminate data races for strMiscWarning and fLargeWork*Found. (Gregory Maxwell) c63198f Make QT runawayException call GetWarnings instead of directly access strMiscWarning. (Gregory Maxwell)
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 26, 2019
…, make QT runawayException use GetWarnings 749be01 Move GetWarnings() into its own file. (Gregory Maxwell) e3ba0ef Eliminate data races for strMiscWarning and fLargeWork*Found. (Gregory Maxwell) c63198f Make QT runawayException call GetWarnings instead of directly access strMiscWarning. (Gregory Maxwell)
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Feb 21, 2020
Upstream PRs relating to strMiscWarning This pulls in upstream PRs bitcoin/bitcoin#7114 and bitcoin/bitcoin#9236 (non-QT parts). * Fixes bitcoin/bitcoin#6809 - run-of-the-mill exceptions should not get into `strMiscWarning` (which is reported by `getinfo`). * Eliminate data races for `strMiscWarning` and `fLargeWork*Found`. This moves all access to these data structures through accessor functions and protects them with a lock.
denverbdr
pushed a commit
to ycashfoundation/ycash
that referenced
this pull request
Mar 6, 2020
Upstream PRs relating to strMiscWarning This pulls in upstream PRs bitcoin/bitcoin#7114 and bitcoin/bitcoin#9236 (non-QT parts). * Fixes bitcoin/bitcoin#6809 - run-of-the-mill exceptions should not get into `strMiscWarning` (which is reported by `getinfo`). * Eliminate data races for `strMiscWarning` and `fLargeWork*Found`. This moves all access to these data structures through accessor functions and protects them with a lock.
random-zebra
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Dec 17, 2020
…ound 97a85eb [GUI] Connect alert signal (furszy) ce58263 Move GetWarnings() into its own file. (furszy) 3fee808 util GetWarnings, adding "gui" parameter type. (furszy) e074feb Eliminate data races for strMiscWarning and fLargeWork*Found. This moves all access to these datastructures through accessor functions and protects them with a lock. (furszy) 5fdd73e Make QT runawayException call GetWarnings instead of directly access strMiscWarning. (furszy) c684718 Separate CTranslationInterface from CClientUIInterface (furszy) 0b62015 [Cleanup] Remove unused global fields from util.h/cpp (furszy) Pull request description: Back ported two different PRs from upstream to solve possible races over the `strMiscWarning` and `fLargeWork*Found` global fields plus some small cleanup. dashpay#6022: to not depend on `guiinterface.h` every time that a back end text needs translations. bitcoin#9236: eliminating data races for strMiscWarning and fLargeWork*Found and making QT `runawayException` call `GetWarnings("gui")` instead of directly access `strMiscWarning`. Extra information: This work is part of a larger rabbit hole that i'm working on to be able to solve #1973 current issues and compile the project in macOS again (solving the newer boost version errors). ACKs for top commit: Fuzzbawls: ACK 97a85eb random-zebra: utACK 97a85eb and merging... Tree-SHA512: 0a2549f19ecadff1c3e275649599e9cf043404a213f8418e85cc009d7f56c98c704de53f3700a88acd9cdaf1e5ff73bc3b1d9951d76469c7283d2e7cfaaf6628
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminate data races for strMiscWarning and fLargeWork*Found.
This moves all access to these datastructures through accessor functions and protects them with a lock.
and
Make QT runawayException call GetWarnings("gui") instead of directly access strMiscWarning.