torcontrol: Explicitly request RSA1024 private key #9234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating a new service key, explicitly request a RSA1024 one. The bitcoin P2P protocol has no support for the longer hidden service names that will come with ed25519 keys, until it does, we depend on the old hidden service type so make this explicit. See bitcoin#9214.
laanwj
force-pushed
the
2016_11_torcontrol_key_ttpe
branch
from
6da5810 to
7d3b627
Compare
Contributor
|
utACK |
Member
|
utACK 7d3b627 |
Member
|
utACK 7d3b627 |
1 similar comment
Contributor
|
utACK 7d3b627 |
Contributor
|
utACK; do we know how far back tor version wise this is supported? |
Member
Author
|
I'm quite sure choosing "RSA1024" instead of "BEST" has always been
supported - why have a key type parameter otherwise.
The only reason I've chosen "BEST" here originally was that I was unaware
that a different key type could change the address format to something
bitcoin can't handle.
|
Member
Author
|
The parameter is documented here: https://gitweb.torproject.org/torspec.git/tree/control-spec.txt#n1446 There is no mention of any version constraints relevant to KeyBlob. |
|
ACK. I confirm explicitly asking for the key type is supported for as far back as ADD_ONION is. Until RSA1024 keys (v2 HS) are permanently rejected in the Tor network, this patch should work. It's useless to ask for |
Contributor
|
ACK. (tested now) |
laanwj
added a commit
that referenced
this pull request
Nov 30, 2016
7d3b627 torcontrol: Explicitly request RSA1024 private key (Wladimir J. van der Laan)
laanwj
added a commit
that referenced
this pull request
Nov 30, 2016
When generating a new service key, explicitly request a RSA1024 one. The bitcoin P2P protocol has no support for the longer hidden service names that will come with ed25519 keys, until it does, we depend on the old hidden service type so make this explicit. See #9214. Rebased-From: 7d3b627 Github-Pull: #9234
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Nov 30, 2016
When generating a new service key, explicitly request a RSA1024 one. The bitcoin P2P protocol has no support for the longer hidden service names that will come with ed25519 keys, until it does, we depend on the old hidden service type so make this explicit. See bitcoin#9214. Github-Pull: bitcoin#9234 Rebased-From: 7d3b627
Member
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Mar 22, 2017
When generating a new service key, explicitly request a RSA1024 one. The bitcoin P2P protocol has no support for the longer hidden service names that will come with ed25519 keys, until it does, we depend on the old hidden service type so make this explicit. See bitcoin#9214. Github-Pull: bitcoin#9234 Rebased-From: 7d3b627
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Mar 26, 2017
Tor ephemeral hidden services Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6503 (included to reduce merge conflicts) - bitcoin/bitcoin#6639 - bitcoin/bitcoin#6643 - bitcoin/bitcoin#7090 - bitcoin/bitcoin#7035 - bitcoin/bitcoin#7170 - bitcoin/bitcoin#7218 (non-QT part) - bitcoin/bitcoin#7313 - bitcoin/bitcoin#7438 - bitcoin/bitcoin#7553 - bitcoin/bitcoin#7637 - bitcoin/bitcoin#7683 - bitcoin/bitcoin#7813 - bitcoin/bitcoin#7703 - bitcoin/bitcoin#8203 - bitcoin/bitcoin#9004 - bitcoin/bitcoin#9234 - bitcoin/bitcoin#9911 (partial) Closes #2061.
UdjinM6
added a commit
to dashpay/dash
that referenced
this pull request
Apr 11, 2017
* Implement BIP 9 GBT changes - BIP9DeploymentInfo struct for static deployment info - VersionBitsDeploymentInfo: Avoid C++11ism by commenting parameter names - getblocktemplate: Make sure to set deployments in the version if it is LOCKED_IN - In this commit, all rules are considered required for clients to support * qa/rpc-tests: bip9-softforks: Add tests for getblocktemplate versionbits updates * getblocktemplate: Explicitly handle the distinction between GBT-affecting softforks vs not * getblocktemplate: Use version/force mutation to support pre-BIP9 clients * Don't use floating point Github-Pull: bitcoin#8317 Rebased-From: 477777f * Send tip change notification from invalidateblock This change is needed to prevent sync_blocks timeouts in the mempool_reorg test after the sync_blocks update in the upcoming commit "[qa] Change sync_blocks to pick smarter maxheight". This change was initially suggested by Suhas Daftuar <[email protected]> in bitcoin#8680 (comment) Github-Pull: bitcoin#9196 Rebased-From: 67c6326 * torcontrol: Explicitly request RSA1024 private key When generating a new service key, explicitly request a RSA1024 one. The bitcoin P2P protocol has no support for the longer hidden service names that will come with ed25519 keys, until it does, we depend on the old hidden service type so make this explicit. See bitcoin#9214. Github-Pull: bitcoin#9234 Rebased-From: 7d3b627 * Bugfix: FRT: don't terminate when keypool is empty Github-Pull: bitcoin#9295 Rebased-From: c24a4f5 * add fundrawtransaction test on a locked wallet with empty keypool Github-Pull: bitcoin#9295 Rebased-From: 1a6eacb
thokon00
pushed a commit
to faircoin/faircoin
that referenced
this pull request
Apr 17, 2018
When generating a new service key, explicitly request a RSA1024 one. The bitcoin P2P protocol has no support for the longer hidden service names that will come with ed25519 keys, until it does, we depend on the old hidden service type so make this explicit. See bitcoin#9214. Github-Pull: bitcoin#9234 Rebased-From: 7d3b627
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating a new service key, explicitly request a RSA1024 one.
The bitcoin P2P protocol has no support for the longer hidden service names that will come with ed25519 keys, until it does, we depend on the old hidden service type so make this explicit.
See #9214.