Prevent FD_SETSIZE error building on OpenBSD #9224
Conversation
|
Hardcoding it is wrong for systems other than windows. If it's missing on OpenBSD it may be necessary to add another header. select.h would be an obvious candidate. |
|
FD_SETSIZE has historically been able to be overridden on most systems, but unfortunately IIRC some years ago glibc hard-coded it so it cannot be changed. :( |
|
ACK after squash. Adding a header is the right thing to do. I wonder why you need this though, I have built many times on OpenBSD (https://github.com/bitcoin/bitcoin/blob/master/doc/build-openbsd.md) without stumbling on this issue. |
|
I started using OpenBSD again after some time. I upgraded to -current and followed the instructions in build-openbsd.md and got the error that FD_SETSIZE was undeclared. |
laanwj
force-pushed
the
unix-compilation
branch
from
0bea6fc to
498a1d7
Compare
laanwj
changed the title
498a1d7 Include select.h when WIN32 is not defined (Ivo van der Sangen)
Github-Pull: bitcoin#9224 Rebased-From: 498a1d7
498a1d7 Include select.h when WIN32 is not defined (Ivo van der Sangen)
498a1d7 Include select.h when WIN32 is not defined (Ivo van der Sangen)
498a1d7 Include select.h when WIN32 is not defined (Ivo van der Sangen)
4 participants
This fixes the build in cases WIN32 is not defined. At least on OpenBSD this made the build work.