[Doc] Move comments above bash command in build-unix #9207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laanwj
reviewed
Nov 23, 2016
doc/build-unix.md
Outdated
Member
There was a problem hiding this comment.
Alternatively this (...) could go after Optional in the previous line. The less to copy/paste the better I'd say, and comments don't really make that much sense here.
(same below)
Contributor
Author
There was a problem hiding this comment.
Okay, I will move the comments above the code.
AmirAbrams
changed the title
Contributor
|
ACK 69bc8e7 |
Contributor
Author
|
@laanwj, I moved the comments above as requested and squashed my commit. |
Member
|
utACK 69bc8e7 |
Contributor
|
ACK 69bc8e7 |
laanwj
added a commit
that referenced
this pull request
Nov 23, 2016
69bc8e7 [Doc] Move comments above bash command (Amir Abrams)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 15, 2018
69bc8e7 [Doc] Move comments above bash command (Amir Abrams)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
69bc8e7 [Doc] Move comments above bash command (Amir Abrams)
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 24, 2019
69bc8e7 [Doc] Move comments above bash command (Amir Abrams)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For most it is obvious that you need to remove the comments or add the # in front but without it, I get this error: