Make orphan parent fetching ask for witnesses. #9188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 0.13 orphan transactions began being treated as implicit INVs for their parents. But the resulting getdata were not getting the witness flag. This fixes issue #9182 reported by chjj and roasbeef on IRC.
Contributor
Author
|
This should be tagged for backport. |
Member
|
utACK 5b0150a |
1 similar comment
Member
|
utACK 5b0150a |
Contributor
|
utACK |
2 similar comments
Member
|
utACK |
Contributor
|
utACK |
Contributor
|
tested ACK @laanwj ready for merge |
sipa
added a commit
that referenced
this pull request
Dec 1, 2016
5b0150a Make orphan parent fetching ask for witnesses. (Gregory Maxwell)
Merged
Member
|
Backported in #9264, removing tag. |
laanwj
pushed a commit
to laanwj/bitcoin
that referenced
this pull request
Dec 2, 2016
In 0.13 orphan transactions began being treated as implicit INVs for their parents. But the resulting getdata were not getting the witness flag. This fixes issue bitcoin#9182 reported by chjj and roasbeef on IRC. Github-Pull: bitcoin#9188 Rebased-From: 5b0150a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 0.13 orphan transactions began being treated as implicit
INVs for their parents. But the resulting getdata were
not getting the witness flag.
This fixes issue #9182 reported by chjj and roasbeef on IRC.