Skip to content

Set DEFAULT_LIMITFREERELAY = 0 kB/minute #9179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laanwj merged 1 commit into from
Nov 21, 2016
Merged

Set DEFAULT_LIMITFREERELAY = 0 kB/minute #9179

laanwj merged 1 commit into from
Nov 21, 2016

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Nov 17, 2016

No description provided.

@maflcko maflcko added this to the 0.14.0 milestone Nov 17, 2016
@Mirobit
Copy link
Contributor

Mirobit commented Nov 18, 2016 •
edited
Loading

ACK
My nodes get flooded with these 2 year old spam transactions after every block:
27cdfec78b2e0e97762a8486d5440bfc02dac3c2cd278ac803b81062c7212332

@sdaftuar
Copy link
Member

sdaftuar commented Nov 19, 2016

Concept ACK.

Is it worth warning users of the parameter interaction if they are setting -relaypriority=0?

@maflcko
Copy link
Member Author

maflcko commented Nov 20, 2016

Is it worth warning users of the parameter interaction if they are setting -relaypriority=0?

Suggestions welcome, but I am not sure if this is required. I understand the relaypriority setting is orthogonal to the limitfreerelay setting. If the user set -relaypriority=0 today, they'd still see their transaction rate limited (with 15 kB/min). So when they depend on free relay, they most likely adjusted their -limitfreerelay setting anyway.

luke-jr
luke-jr reviewed Nov 20, 2016
View reviewed changes
doc/release-notes.md

- The concept of "priority" transactions is planned to be removed in the next
major version. To prepare for this, the default for the rate limit of priority
transactions (`-limitfreerelay`) has been set to `0` kB/minute.
Copy link
Member

@luke-jr luke-jr Nov 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK. There is no plan to remove priority transactions, only "smart priority" attempting to use it. Don't confuse priority with gratis txns... they are different.

@sipa
Copy link
Member

sipa commented Nov 20, 2016

@luke-jr Sorry, but we're planning to remove priority. It is no longer useful to maintain.

@laanwj
Copy link
Member

laanwj commented Nov 21, 2016

utACK fa7cc5a

@laanwj laanwj merged commit fa7cc5a into bitcoin:master Nov 21, 2016
laanwj added a commit that referenced this pull request Nov 21, 2016
@laanwj
Merge #9179: Set DEFAULT_LIMITFREERELAY = 0 kB/minute
b9a87b4 
fa7cc5a Set DEFAULT_LIMITFREERELAY = 0 kB/minute (MarcoFalke)
@maflcko maflcko deleted the Mf1611-blockFreeTxs branch November 21, 2016 15:32
@luke-jr
Copy link
Member

luke-jr commented Dec 2, 2016

@sipa It remains useful and used. NACK removing it from mining.

@jonathancross jonathancross mentioned this pull request Dec 3, 2016
Closed
codablock pushed a commit to codablock/dash that referenced this pull request Jan 15, 2018
@laanwj @codablock
Merge bitcoin#9179: Set DEFAULT_LIMITFREERELAY = 0 kB/minute
726dd1f 
fa7cc5a Set DEFAULT_LIMITFREERELAY = 0 kB/minute (MarcoFalke)
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
@laanwj @andvgal
Merge bitcoin#9179: Set DEFAULT_LIMITFREERELAY = 0 kB/minute
77b4f64 
fa7cc5a Set DEFAULT_LIMITFREERELAY = 0 kB/minute (MarcoFalke)
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Feb 24, 2019
@laanwj @CryptoCentric
Merge bitcoin#9179: Set DEFAULT_LIMITFREERELAY = 0 kB/minute
6121b5e 
fa7cc5a Set DEFAULT_LIMITFREERELAY = 0 kB/minute (MarcoFalke)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@luke-jr luke-jr luke-jr left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

TX fees and policy

Projects

None yet

Milestone

0.14.0

Development

Successfully merging this pull request may close these issues.

6 participants

@maflcko @Mirobit @sdaftuar @sipa @laanwj @luke-jr