Globals: Pass Consensus::Params through CBlockTreeDB::LoadBlockIndexGuts() #9176
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
jtimon
force-pushed
the
0.13-chainparams-loadblockindexguts
branch
from
312e742 to
2d194fa
Compare
mrbandrews
reviewed
Nov 17, 2016
src/txdb.cpp
Outdated
Contributor
There was a problem hiding this comment.
Nit: if you're changing to use func, there's another opportunity to do so a few lines below so the style is consistent.
Contributor
|
Code review ACK |
jtimon
force-pushed
the
0.13-chainparams-loadblockindexguts
branch
from
2d194fa to
777616e
Compare
Contributor
Author
|
Updated fixing @mrbandrews 's nit. |
jtimon
force-pushed
the
0.13-chainparams-loadblockindexguts
branch
from
777616e to
9aaa82d
Compare
Contributor
Author
|
Needed rebase after renaming main.o, see #9260 (although needed, the rebase was clean in this case) |
jtimon
force-pushed
the
0.13-chainparams-loadblockindexguts
branch
from
9aaa82d to
b324b28
Compare
Contributor
Author
|
Needed rebase |
Member
|
utACK b324b28 |
laanwj
added a commit
that referenced
this pull request
Jun 25, 2017
…adBlockIndexGuts() b324b28 Globals: Pass Consensus::Params through CBlockTreeDB::LoadBlockIndexGuts() (Jorge Timón) Tree-SHA512: 9ef561a026960dc69df52603f4d60246c913bdd127465e8238f0954c6bbbc6b8b3b039bab70df38be1cbf5d06788fb631a2236b49c0167633d54366103c7c055
12 tasks
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 11, 2019
…eDB::LoadBlockIndexGuts() b324b28 Globals: Pass Consensus::Params through CBlockTreeDB::LoadBlockIndexGuts() (Jorge Timón) Tree-SHA512: 9ef561a026960dc69df52603f4d60246c913bdd127465e8238f0954c6bbbc6b8b3b039bab70df38be1cbf5d06788fb631a2236b49c0167633d54366103c7c055
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7829