-
Notifications
You must be signed in to change notification settings - Fork 38.7k
[qt] Make network disabled icon 50% opaque #9145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/qt/res/src/network_disabled.svg
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this only re-sorted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inkscape did this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So don't use Inkscape...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed sorting nit
src/qt/res/src/network_disabled.svg
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The size of the SVG isn't changed...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not required. You can tell the program of your choice what dpi to sample at.
Nonetheless, I changed it to 92 for this svg, as well as for all connect-$N.svg
|
utACK fa30b060eec1f51238292a63039dcc7943abf236 SVG's XML is interpreted and created differently. No need for bikeshedding there. |
fa30b06 to
fa42e4a
Compare
|
Nice and reviewable now 👍 |
fa42e4a [qt] Make network disabled icon 50% opaque (MarcoFalke)
|
Thanks to both Marco and Luke! |
Github-Pull: bitcoin#9145 Rebased-From: fa42e4a
fa42e4a [qt] Make network disabled icon 50% opaque (MarcoFalke)
Bitcoin bitcoin#9145 made the icon 50% opaque, copy that to all themes.
fa42e4a [qt] Make network disabled icon 50% opaque (MarcoFalke)
Bitcoin bitcoin#9145 made the icon 50% opaque, copy that to all themes.
fa42e4a [qt] Make network disabled icon 50% opaque (MarcoFalke)

The png was sampled too low, so displayed incorrectly on high res displays. Also, I modified the alpha channel a bit.