Change sync_blocks to pick smarter maxheight (on top of #9196) #9139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is needed to prevent sync_blocks timeouts in the mempool_reorg test after the sync_blocks update in the upcoming commit "[qa] Change sync_blocks to pick smarter maxheight". This change was initially suggested by Suhas Daftuar <[email protected]> in bitcoin#8680 (comment)
Instead of syncing to max height returned by the waitforblockheight RPC, sync to the max height returned by the getblockcount RPC. This change was suggested by Suhas Daftuar <[email protected]>.
ryanofsky
force-pushed
the
sync-height
branch
from
51937a4 to
d0e07e6
Compare
ryanofsky
changed the title
ryanofsky
force-pushed
the
sync-height
branch
from
d0e07e6 to
863b6e7
Compare
ryanofsky
changed the title
ryanofsky
force-pushed
the
sync-height
branch
from
863b6e7 to
b0e57bd
Compare
Contributor
Author
|
Rearranged if-conditions as suggested offline by @morcos. |
maflcko
reviewed
Nov 15, 2016
qa/rpc-tests/test_framework/util.py
Outdated
Member
There was a problem hiding this comment.
Does this comment still apply, considering that you switched from 0 to getblockcount?
Contributor
Author
There was a problem hiding this comment.
This change might make the problem less likely to happen, but it still could happen. If none of the nodes in the set are fully synced when the sync_blocks call is made, then maxheight will be set to some height less than the final stable height, and the call could return before the nodes are all synced.
Member
|
Concept ACK |
Contributor
|
ACK |
Member
|
@ryanofsky The 60cf51c patch looks like a separate bugfix, not strictly related to tests. Would you mind submitting this as another pull request? |
ryanofsky
force-pushed
the
sync-height
branch
from
b0e57bd to
1126c85
Compare
ryanofsky
changed the title
maflcko
pushed a commit
that referenced
this pull request
Nov 23, 2016
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 17, 2018
…top of bitcoin#9196) 1126c85 [qa] Change sync_blocks to pick smarter maxheight (Russell Yanofsky)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
…top of bitcoin#9196) 1126c85 [qa] Change sync_blocks to pick smarter maxheight (Russell Yanofsky)
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 25, 2019
…top of bitcoin#9196) 1126c85 [qa] Change sync_blocks to pick smarter maxheight (Russell Yanofsky)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
sync_blockstest function to make it more reliable.The change is based on #9196 to prevent a test failure that would otherwise start to happen.