fix getnettotals RPC description about timemillis. #9122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
utACK, this matches with what is actually returned. Not sure how "cpu time" ended up there, there is no functionality to measure that anywhere in bitcoind. |
Member
Member
|
utACK a79f864 |
maflcko
pushed a commit
that referenced
this pull request
Nov 10, 2016
a79f864 fix getnettotals RPC description about timemillis. (Masahiko Hyuga)
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Dec 2, 2016
Github-Pull: bitcoin#9122 Rebased-From: a79f864
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 15, 2018
a79f864 fix getnettotals RPC description about timemillis. (Masahiko Hyuga)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
a79f864 fix getnettotals RPC description about timemillis. (Masahiko Hyuga)
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 24, 2019
a79f864 fix getnettotals RPC description about timemillis. (Masahiko Hyuga)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Help message says that
timemillisreturned bygetnettotalsRPC call is "Total cpu time" but it is actually a local UNIX time returned byGetTimeMillis()(written insrc/utiltime.cpp).Fixed the help message to fit the actual value returned.