Skip to content

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Nov 7, 2016

preciousblock.py:

  • Use assert_equal(), so failures are more verbose
  • Also some trivial refactoring

sync_*():

  • Only allow named args and add timeout to sync_chain()
  • Make failures more verbose

@maflcko maflcko added the Tests label Nov 7, 2016
* Only allow named args in sync_*()
* Make sync_* fails more verbose
* Add timeout to sync_chain()
@maflcko maflcko force-pushed the Mf1611-qaSyncAndPrecious branch from fa3fedf to fa97ccb Compare November 7, 2016 19:42
@jtimon
Copy link
Contributor

jtimon commented Nov 7, 2016

Concept ACK

@maflcko maflcko merged commit fa97ccb into bitcoin:master Nov 10, 2016
maflcko pushed a commit that referenced this pull request Nov 10, 2016
fa97ccb [qa] util: Rework sync_*() (MarcoFalke)
fac1141 [qa] preciousblock: Use assert_equal and BitcoinTestFramework.__init__ (MarcoFalke)
@maflcko maflcko deleted the Mf1611-qaSyncAndPrecious branch November 10, 2016 10:24
luke-jr pushed a commit to bitcoinknots/bitcoin that referenced this pull request Dec 21, 2016
codablock pushed a commit to codablock/dash that referenced this pull request Jan 15, 2018
fa97ccb [qa] util: Rework sync_*() (MarcoFalke)
fac1141 [qa] preciousblock: Use assert_equal and BitcoinTestFramework.__init__ (MarcoFalke)
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
fa97ccb [qa] util: Rework sync_*() (MarcoFalke)
fac1141 [qa] preciousblock: Use assert_equal and BitcoinTestFramework.__init__ (MarcoFalke)
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Feb 24, 2019
fa97ccb [qa] util: Rework sync_*() (MarcoFalke)
fac1141 [qa] preciousblock: Use assert_equal and BitcoinTestFramework.__init__ (MarcoFalke)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants