Trivial: Add common failure cases for rpc server connection failure #9073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paveljanik
reviewed
Nov 3, 2016
src/bitcoin-cli.cpp
Outdated
Contributor
There was a problem hiding this comment.
nit: please remove space before :.
instagibbs
force-pushed
the
rpcnoconnectstring
branch
from
b765a71 to
e7cd2de
Compare
Member
|
Concept ACK, but I think this message is becoming too long to be crammed into one line. I think it'd make sense to write it out over multiple lines, e.g. leave the last line for the detailed error message (if any). |
instagibbs
force-pushed
the
rpcnoconnectstring
branch
from
e7cd2de to
8f329f9
Compare
Member
Author
|
added newline to break it up some of the text |
Member
|
utACK 8f329f9 |
Member
|
Tested ACK 8f329f9 |
laanwj
added a commit
that referenced
this pull request
Nov 3, 2016
…ion failure 8f329f9 Add common failure cases for rpc server connection failure (instagibbs)
Member
|
This is a bit confusing now: If you don't know better it seems like the port is unknown. I think this would be better: |
laanwj
added a commit
to laanwj/bitcoin
that referenced
this pull request
Dec 2, 2016
Sorry for the churn on this, but the current message (introduced in bitcoin#9073) isn't acceptable: $ src/bitcoin-cli getinfo rpc: couldn't connect to server (make sure server is running and you are connecting to the correct RPC port: -1 unknown) Putting the error code after the words "RPC port" made me wonder whether there was a port configuration issue. This changes it to: $ src/bitcoin-cli getinfo error: couldn't connect to server: unknown (code -1) (make sure server is running and you are connecting to the correct RPC port)
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Mar 22, 2017
libevent-based http server Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#5677 - bitcoin/bitcoin#6695 - bitcoin/bitcoin#6899 - bitcoin/bitcoin#7016 - bitcoin/bitcoin#7964 - bitcoin/bitcoin#8722 - bitcoin/bitcoin#8730 - bitcoin/bitcoin#9073 - bitcoin/bitcoin#9265 - bitcoin/bitcoin#9387 - bitcoin/bitcoin#9471 - bitcoin/bitcoin#9647 - bitcoin/bitcoin#9903 Closes #1593 and #1856.
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Mar 25, 2017
libevent-based http server Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#5677 - bitcoin/bitcoin#6695 - bitcoin/bitcoin#6899 - bitcoin/bitcoin#7016 - bitcoin/bitcoin#7964 - bitcoin/bitcoin#8722 - bitcoin/bitcoin#8730 - bitcoin/bitcoin#9073 - bitcoin/bitcoin#9265 - bitcoin/bitcoin#9387 - bitcoin/bitcoin#9471 - bitcoin/bitcoin#9647 - bitcoin/bitcoin#9903 - bitcoin/bitcoin#6640 - bitcoin/bitcoin#8139 - bitcoin/bitcoin#8839 Closes #1593 and #1856.
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 13, 2018
…connection failure 8f329f9 Add common failure cases for rpc server connection failure (instagibbs)
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Jan 4, 2019
Sorry for the churn on this, but the current message (introduced in bitcoin#9073) isn't acceptable: $ src/bitcoin-cli getinfo rpc: couldn't connect to server (make sure server is running and you are connecting to the correct RPC port: -1 unknown) Putting the error code after the words "RPC port" made me wonder whether there was a port configuration issue. This changes it to: $ src/bitcoin-cli getinfo error: couldn't connect to server: unknown (code -1) (make sure server is running and you are connecting to the correct RPC port)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
…connection failure 8f329f9 Add common failure cases for rpc server connection failure (instagibbs)
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 15, 2019
…connection failure 8f329f9 Add common failure cases for rpc server connection failure (instagibbs)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now if you're not familiar with the other error responses, you might not know why connection failed. Give common reasons for this particular error message.