Declare wallet.h functions inline #9071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Yea, sure. Though I am morally offended by the compiler warning about it. :P (utACK) |
Member
|
utACK 2ca882a. |
Contributor
|
utACK 2ca882a |
Contributor
Member
|
I feel offended because I am not presented this warning even after cherry-picking the commits in #9039 |
Contributor
|
Looks like we have to put some bounty for the solution - 100 tBTC from me for explanation :-) |
Member
|
I'm morally offended by having to merge this obscene change. utACK 2ca882a |
laanwj
added a commit
that referenced
this pull request
Nov 3, 2016
2ca882a Declare wallet.h functions inline (Pieter Wuille)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 13, 2018
2ca882a Declare wallet.h functions inline (Pieter Wuille)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
2ca882a Declare wallet.h functions inline (Pieter Wuille)
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 15, 2019
2ca882a Declare wallet.h functions inline (Pieter Wuille)
CryptoCentric
added a commit
to absolute-community/absolute
that referenced
this pull request
Feb 15, 2019
2ca882a Declare wallet.h functions inline (Pieter Wuille)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by @paveljanik in #9039, the function whose definition is in wallet/wallet.h should be declared inline, and clang warns about this. Do what it says.