Skip to content

Conversation

@unsystemizer
Copy link
Contributor

This new feature is enabled by default if Bitcoin Core is listening, and a connection to Tor can be made. It can be configured with the -listenonion, -torcontrol and -torpassword settings. To show verbose debugging information, pass -debug=tor.

But it is correct to say that the feature is enabled regardless of whether a connection to Tor can be made.

I propose to clarify that so that users can eliminate these in their logs (when listen=1 and no Tor).
And I think it's okay to clarify about the listen option, because on several occasions when I read this before I always assumed listening meant server=1 which cost me a lot of time in troubleshooting.

2016-10-24 06:19:22.551029 tor: Error connecting to Tor control socket
2016-10-24 06:19:22.551700 tor: Not connected to Tor control port 127.0.0.1:9051, trying to reconnect

What version of bitcoin-core are you using?

0.12.1

> This new feature is enabled by default if Bitcoin Core is listening, and a connection to Tor can be made. It can be configured with the -listenonion, -torcontrol and -torpassword settings. To show verbose debugging information, pass -debug=tor.

But it is correct to say that the feature is enabled *regardless* of whether a connection to Tor can be made.

I propose to clarify that so that users can eliminate these in their logs (when `listen=1` and no Tor).
And I think it's okay to clarify about the `listen` option, because on several occasions when I read this before I always assumed `listening` meant `server=1` which cost me a lot of time in troubleshooting.

```
2016-10-24 06:19:22.551029 tor: Error connecting to Tor control socket
2016-10-24 06:19:22.551700 tor: Not connected to Tor control port 127.0.0.1:9051, trying to reconnect
```

### What version of bitcoin-core are you using?
0.12.1
@fanquake fanquake added the Docs label Oct 24, 2016
@laanwj
Copy link
Member

laanwj commented Oct 24, 2016

Yes, server and listen are named awkwardly, one relates to RPC where the other does to P2P.
Documentation change looks good to me.

@btcdrak
Copy link
Contributor

btcdrak commented Oct 24, 2016

ACK

@laanwj laanwj merged commit 3421e74 into bitcoin:master Oct 25, 2016
laanwj added a commit that referenced this pull request Oct 25, 2016
3421e74 Clarify `listenonion` (unsystemizer)
@unsystemizer unsystemizer deleted the patch-3 branch October 25, 2016 05:39
codablock pushed a commit to codablock/dash that referenced this pull request Jan 13, 2018
3421e74 Clarify `listenonion` (unsystemizer)
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
3421e74 Clarify `listenonion` (unsystemizer)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants