Do not invoke anti-DoS system for invalid BIP16 transactions #896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing so would allow an attack on old nodes, which would relay a standard transaction spending a BIP16 output in an invalid way, until reaching a new node, which will disconnect their peer. Reported by makomk on IRC.
|
Looks good to me! Note that this isn't exactly an attack on old nodes though. Unless it's increased recently, under half of all blocks mined are from P2SH nodes, which means that they'd probably be the ones that would be most affected by the Bitcoin network attempting to partition itself into old and new nodes in this way. Then there's the issue of giving an attacker a tool that helps them create a network partition with a useful proportion of miners on each side in the first place. I also wonder if a similar issue will apply to blocks after P2SH is switched on fully; could they cause the P2SH part of the network to cut itself off from the non-P2SH part? |
Contributor
|
ACK, nice fix. |
suprnurd
pushed a commit
to chaincoin-legacy/chaincoin
that referenced
this pull request
Dec 5, 2017
1ca59fe update contrib/debian 7ad1ea8 fix some nits 05e0a12 updated pixmap references to dash da7ef9c rename - bitcoin*.png to dash*.png - bitcoin*.xpm to dash*.xpm d0d2f05 Update Dash description in Debian control to match the description in the main README.md file 3dc2bab Update Dash description in Debian control to match the description in the main README.md file - this merges the latest Bitcoin changes and should enable us to provide Dash PPAs via https://launchpad.net/~dash.org/+archive/ubuntu/dash Closes bitcoin#880
ptschip
pushed a commit
to ptschip/bitcoin
that referenced
this pull request
Jan 11, 2018
* Use UTF-8 to encode chainparams.cpp * Remove BOM char from src/config.h
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Oct 30, 2019
d7afebb [UI] Simplify Qt margins. No functional change. (warrows) Tree-SHA512: c29c1d416d81ccda15d90c26fcadc9b67dcd27b8b7bdbd55c951e0ddd6c809b0cc7cc0dfc3590dc45fa2fb4f0e5218d9da2a424cb3a953d9b542de34ab7b693c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing so would allow an attack on old nodes, which would relay a
standard transaction spending a BIP16 output in an invalid way,
until reaching a new node, which will disconnect their peer.
Reported by makomk on IRC.