-
Notifications
You must be signed in to change notification settings - Fork 38.6k
[Testing] Include fRelay in mininode version messages #8894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Are you sure that the field is required? The BIP implies that the field is optional:
|
|
@MarcoFalke Yes - you're correct. I didn't read the BIP closely enough. Still, I think mininode should specify the |
|
It makes sense for the test framework to support this. |
Sure. Please also make sure to deserialize nRelay and mention it in the repr. |
|
Agree with @MarcoFalke, you should extend the change to the deserialization method. |
|
@jnewbery Are you still working on this? |
ce364a1 to
6a4ed9d
Compare
6a4ed9d to
e5d682f
Compare
|
@MarcoFalke : deserialization and repr methods updated. |
|
Thanks, utACK e5d682f |
e5d682f Fix mininode version message format (jnewbery)
…ages e5d682f Fix mininode version message format (jnewbery)
…ages e5d682f Fix mininode version message format (jnewbery)
…ages e5d682f Fix mininode version message format (jnewbery)
In protocol version 70001, an additional field
fRelaywas added to the version message (see https://github.com/bitcoin/bips/blob/master/bip-0037.mediawiki#extensions-to-existing-messages ).Mininode does not currently include the
fRelayfield in its version messages, and so is technically sending malformed version messages. This PR fixes mininode's version messages.