Skip to content

Add some verbose logging to bitcoin-util-test.py #8881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maflcko merged 1 commit into from
Oct 8, 2016
Merged

Add some verbose logging to bitcoin-util-test.py #8881

maflcko merged 1 commit into from
Oct 8, 2016

Conversation

@jnewbery
Copy link
Contributor

@jnewbery jnewbery commented Oct 4, 2016

Adds a new command line parameter to output verbose logging when running bitcoin-util-test.py manually.

@jnewbery
Copy link
Contributor Author

jnewbery commented Oct 4, 2016

Sample output:

~/bitcoin/src$ test/bitcoin-util-test.py --srcdir='.' --verbose
Testing: Creates a blank transaction
PASS
Testing: Creates a blank transaction (output in json)
PASS
Testing: Creates a blank transaction when nothing is piped into bitcoin-tx
PASS
Testing: Creates a blank transaction when nothing is piped into bitcoin-tx (output in json)
PASS
Testing: Deletes a single input from a transaction
PASS
Testing: Deletes a single input from a transaction (output in json)
PASS
Testing: Attempts to delete an input with a bad index from a transaction. Expected to fail.
PASS
Testing: Deletes a single output from a transaction
PASS
Testing: Deletes a single output from a transaction (output in json)
PASS
Testing: Attempts to delete an output with a bad index from a transaction. Expected to fail.
PASS
Testing: Adds an nlocktime to a transaction
PASS
Testing: Adds an nlocktime to a transaction (output in json)
PASS
Testing: Creates a new transaction with three inputs and two outputs
PASS
Testing: Creates a new transaction with three inputs and two outputs (output in json)
PASS
Testing: Creates a new transaction with a single empty output script
PASS
Testing: Creates a new transaction with a single empty output script (output in json)
PASS
Testing: Creates a new transaction with a single input and a single output, and then signs the transaction
PASS
Testing: Creates a new transaction with a single input and a single output, and then signs the transaction (output in json)
PASS
Testing: Attempts to create a new transaction with one input and an output with malformed hex data. Expected to fail
PASS
Testing: Attempts to create a new transaction with one input and an output with no value and malformed hex data. Expected to fail
PASS
Testing: Creates a new transaction with one input, one address output and one data output
PASS
Testing: Creates a new transaction with one input, one address output and one data output. Output in json
PASS
Testing: Creates a new transaction with one input, one address output and one data (zero value) output
PASS
Testing: Creates a new transaction with one input, one address output and one data (zero value) output. Output in json
PASS
Testing: Creates a new transaction with one input with sequence number and one address output
PASS
Testing: Creates a new transaction with one input with sequence number and one address output. Output in json
PASS
Testing: Adds a new input with sequence number to a transaction
PASS
Testing: Adds a new input with sequence number to a transaction. Output in json
PASS

@fanquake fanquake added the Tests label Oct 5, 2016
fanquake
fanquake reviewed Oct 5, 2016
View reviewed changes
src/test/data/bitcoin-util-test.json Outdated
Copy link
Member

@fanquake fanquake Oct 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: lines from here down can be changed to use "(output in json)" to match the above.

@fanquake
Copy link
Member

fanquake commented Oct 5, 2016

Getting the same output. etc

bash-3.2$ test/bitcoin-util-test.py --srcdir='.' --verbose
Testing: Creates a blank transaction
PASS
Testing: Creates a blank transaction (output in json)
PASS
.......
Testing: Adds a new input with sequence number to a transaction
PASS
Testing: Adds a new input with sequence number to a transaction. Output in json
PASS

@jnewbery jnewbery force-pushed the verbose-bitcoin-util-output branch from 81a40d6 to 621441a Compare October 5, 2016 13:16
@jnewbery
Copy link
Contributor Author

jnewbery commented Oct 5, 2016

Thanks @fanquake . Descriptions fixed and commits squashed.

@maflcko
Copy link
Member

maflcko commented Oct 5, 2016

utACK 621441a

1 similar comment
@jonasschnelli
Copy link
Contributor

jonasschnelli commented Oct 8, 2016

utACK 621441a

@maflcko maflcko merged commit 621441a into bitcoin:master Oct 8, 2016
maflcko pushed a commit that referenced this pull request Oct 8, 2016
Merge #8881: Add some verbose logging to bitcoin-util-test.py
e66cc1d 
621441a add verbose mode to bitcoin-util-test.py (jnewbery)
@jnewbery jnewbery deleted the verbose-bitcoin-util-output branch October 11, 2016 09:07
codablock pushed a commit to codablock/dash that referenced this pull request Jan 12, 2018
@codablock
Merge bitcoin#8881: Add some verbose logging to bitcoin-util-test.py
76641e6 
621441a add verbose mode to bitcoin-util-test.py (jnewbery)
@dagurval dagurval mentioned this pull request Apr 27, 2018
Merged
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
@andvgal
Merge bitcoin#8881: Add some verbose logging to bitcoin-util-test.py
2e2123c 
621441a add verbose mode to bitcoin-util-test.py (jnewbery)
@str4d str4d mentioned this pull request Oct 28, 2020
Merged
zkbot added a commit to zcash/zcash that referenced this pull request Nov 9, 2020
@zkbot
Auto merge of #4835 - str4d:bctest-backports, r=str4d
bd5ff7c 
bitcoin-util-test.py backports

Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#8829
- bitcoin/bitcoin#8830
- bitcoin/bitcoin#8836
- bitcoin/bitcoin#8881
- bitcoin/bitcoin#9032
- bitcoin/bitcoin#9023
- bitcoin/bitcoin#9069
- bitcoin/bitcoin#9945
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fanquake fanquake fanquake left review comments

Assignees

No one assigned

Labels

Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jnewbery @fanquake @maflcko @jonasschnelli