init: Get rid of fDisableWallet #8768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laanwj
reviewed
Sep 20, 2016
src/wallet/wallet.cpp
Outdated
|
|
||
| bool CWallet::InitLoadWallet() | ||
| { | ||
| if (GetBoolArg("-disablewallet", false)) { |
Member
There was a problem hiding this comment.
I wonder why we don't have a constant DEFAULT_DISABLEWALLET like for the other args.
Member
Author
There was a problem hiding this comment.
Maybe some constants are too obvious to have a default value. In the future this might change for -disablewallet and we should introduce the default value.
Member
There was a problem hiding this comment.
But for consistency it'd make sense to have one. When changing the default it's easy enough to forget one of the GetArgs().
Member
|
Concept ACK |
dcousens
approved these changes
Sep 21, 2016
laanwj
approved these changes
Sep 21, 2016
laanwj
added a commit
that referenced
this pull request
Sep 21, 2016
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
random-zebra
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
May 11, 2021
…nit.cpp 4dfc8e0 [MOVE-ONLY] Init: move -resync interaction out of init-wallet (step 5) (random-zebra) 1270ef8 [Refactor] Break up Auto-backup monolithic code in init.cpp (random-zebra) 6ab142b [Refactoring] Move sysperms + enabled wallet check in wallet.cpp (random-zebra) d8d723b [wallet] Introduce DEFAULT_DISABLE_WALLET (MarcoFalke) d098e5b init: Get rid of fDisableWallet (random-zebra) Pull request description: Simple refactoring. First two commits are coming from bitcoin#8768. Other commits break up a big chunk of code from init.cpp into more manageable functions in wallet/walletdb. This will make the implementation of auto-backups for multi-wallets cleaner (will now rebase #2337 on top of this one). ACKs for top commit: furszy: All good, code review ACK 4dfc8e0. Fuzzbawls: ACK 4dfc8e0 Tree-SHA512: d87c8aa7bb5293cc9f15650d4329313a63af8f33f08b82dd8e119a75db3608b4c2535322ccae82b404a68801dba76d858236b9e0c09bc1800f7f7cc0e8f21383
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the disablewallet logic from init.cpp to wallet.cpp
C.f. #7965