Skip to content

Conversation

@fanquake
Copy link
Member

@fanquake fanquake commented Sep 18, 2016

Homebrew now installs Protobuf version 3 by default, which doesn't currently compile. So we should recommend installing Protobuf 2.6.x from the versions tap instead.

Should probably be backported to the 0.13 branch.

Discussion in #8741

Homebrew now installs Protobuf version 3 by default, which doesn't currently compile. Install Protobuf 2.6.x from the versions tap instead.
@droark
Copy link
Contributor

droark commented Sep 18, 2016

I'd add a brief note explaining the protobuf 2.6 requirement. Otherwise, it looks good to me.

@laanwj
Copy link
Member

laanwj commented Sep 19, 2016

utACK b16a7f6

Ref: #8430

For 0.14 I'd prefer that it just builds with protobuf 3.x (as this is going to pop up everywhere), but this is a good intermediate solution. Added the needs backport tag.

@laanwj laanwj merged commit b16a7f6 into bitcoin:master Sep 19, 2016
laanwj added a commit that referenced this pull request Sep 19, 2016
b16a7f6 [Doc] Target protobuf 2.6 in OS X build notes. (Michael Ford)
luke-jr pushed a commit to luke-jr/bitcoin that referenced this pull request Sep 21, 2016
Homebrew now installs Protobuf version 3 by default, which doesn't currently compile. Install Protobuf 2.6.x from the versions tap instead.

Github-Pull: bitcoin#8754
Rebased-From: b16a7f6
@maflcko maflcko added this to the 0.13.1 milestone Sep 24, 2016
@laanwj
Copy link
Member

laanwj commented Sep 26, 2016

This is backported in #8772, removing tag

@fanquake fanquake deleted the osx-protobuf-doc branch September 27, 2016 01:40
codablock pushed a commit to codablock/dash that referenced this pull request Jan 11, 2018
b16a7f6 [Doc] Target protobuf 2.6 in OS X build notes. (Michael Ford)
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
b16a7f6 [Doc] Target protobuf 2.6 in OS X build notes. (Michael Ford)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants