Skip to content

Specify Protobuf version 2 in paymentrequest.proto #8742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laanwj merged 1 commit into from
Sep 19, 2016
Merged

Specify Protobuf version 2 in paymentrequest.proto #8742

laanwj merged 1 commit into from
Sep 19, 2016

Conversation

@fanquake
Copy link
Member

@fanquake fanquake commented Sep 16, 2016 •
edited
Loading

This warning is emitted if compiling with Protobuf version 3 (which is currently failing).

GEN      qt/forms/ui_askpassphrasedialog.h
[libprotobuf WARNING google/protobuf/compiler/parser.cc:547] No syntax specified for the proto file: paymentrequest.proto. 
Please use 'syntax = "proto2";' or 'syntax = "proto3";' to specify a syntax version. 
(Defaulted to proto2 syntax.)

laanwj
laanwj approved these changes Sep 19, 2016
View reviewed changes
Copy link
Member

@laanwj laanwj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK c4084c2

@laanwj laanwj merged commit c4084c2 into bitcoin:master Sep 19, 2016
laanwj added a commit that referenced this pull request Sep 19, 2016
@laanwj
Merge #8742: Specify Protobuf version 2 in paymentrequest.proto
2ebb809 
c4084c2 Specify Protobuf version 2 in paymentrequest.proto (fanquake)
luke-jr pushed a commit to luke-jr/bitcoin that referenced this pull request Sep 21, 2016
@fanquake @luke-jr
Specify Protobuf version 2 in paymentrequest.proto
d31ac72 
Github-Pull: bitcoin#8742
Rebased-From: c4084c2
@maflcko maflcko added this to the 0.13.1 milestone Sep 24, 2016
@laanwj
Copy link
Member

laanwj commented Sep 26, 2016

This is backported in #8772, removing tag

@fanquake fanquake deleted the proto2-vs-proto3 branch September 27, 2016 01:41
codablock pushed a commit to codablock/dash that referenced this pull request Jan 11, 2018
@laanwj @codablock
Merge bitcoin#8742: Specify Protobuf version 2 in paymentrequest.proto
2a13321 
c4084c2 Specify Protobuf version 2 in paymentrequest.proto (fanquake)
lateminer pushed a commit to lateminer/bitcoin that referenced this pull request Nov 11, 2018
@fanquake
Specify Protobuf version 2 in paymentrequest.proto
d39badf 
Github-Pull: bitcoin#8742
Rebased-From: c4084c2
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
@laanwj @andvgal
Merge bitcoin#8742: Specify Protobuf version 2 in paymentrequest.proto
93cfe19 
c4084c2 Specify Protobuf version 2 in paymentrequest.proto (fanquake)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@laanwj laanwj laanwj approved these changes

Assignees

No one assigned

Labels

Utils/log/libs

Projects

None yet

Milestone

0.13.1

Development

Successfully merging this pull request may close these issues.

3 participants

@fanquake @laanwj @maflcko