Skip to content

[qa] wallet: Check legacy wallet as well #8716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laanwj merged 1 commit into from
Sep 19, 2016
Merged

[qa] wallet: Check legacy wallet as well #8716

laanwj merged 1 commit into from
Sep 19, 2016

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Sep 13, 2016

After setting the default of usehd to true, we are no longer testing the legacy wallet.

This pull makes wallet.py test both wallets over time.

@maflcko
Copy link
Member Author

maflcko commented Sep 13, 2016

Unrelated travis failure in untouched script:

stderr:
   File "/home/travis/build/bitcoin/bitcoin/qa/rpc-tests/test_framework/test_framework.py", line 151, in main
    self.run_test()
  File "/home/travis/build/bitcoin/bitcoin/build/../qa/rpc-tests/p2p-compactblocks.py", line 598, in run_test
    self.test_compactblock_construction()
  File "/home/travis/build/bitcoin/bitcoin/build/../qa/rpc-tests/p2p-compactblocks.py", line 248, in test_compactblock_construction
    assert(self.test_node.last_cmpctblock is not None)

laanwj
laanwj reviewed Sep 14, 2016
View reviewed changes
qa/rpc-tests/wallet.py Outdated
Copy link
Member

@laanwj laanwj Sep 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a deterministic sequence here, not random

@maflcko maflcko force-pushed the Mf1609-qaWalletLegacy branch from fafdc40 to faaa533 Compare September 14, 2016 10:09
@maflcko maflcko force-pushed the Mf1609-qaWalletLegacy branch from faaa533 to fa644d0 Compare September 14, 2016 10:15
@laanwj laanwj merged commit fa644d0 into bitcoin:master Sep 19, 2016
laanwj added a commit that referenced this pull request Sep 19, 2016
@laanwj
Merge #8716: [qa] wallet: Check legacy wallet as well
9ac0130 
fa644d0 [qa] wallet: Check legacy wallet as well (MarcoFalke)
@maflcko maflcko deleted the Mf1609-qaWalletLegacy branch September 19, 2016 13:57
luke-jr pushed a commit to luke-jr/bitcoin that referenced this pull request Sep 21, 2016
@luke-jr
[qa] wallet: Check legacy wallet as well
e34374e 
Github-Pull: bitcoin#8716
Rebased-From: fa644d0
codablock pushed a commit to codablock/dash that referenced this pull request Jan 11, 2018
@laanwj @codablock
Merge bitcoin#8716: [qa] wallet: Check legacy wallet as well
699db99 
fa644d0 [qa] wallet: Check legacy wallet as well (MarcoFalke)
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
@laanwj @andvgal
Merge bitcoin#8716: [qa] wallet: Check legacy wallet as well
b473d67 
fa644d0 [qa] wallet: Check legacy wallet as well (MarcoFalke)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Tests Wallet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maflcko @laanwj