-
Notifications
You must be signed in to change notification settings - Fork 38.7k
Remove maxuploadtargets recommended minimum #8712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jonasschnelli
merged 1 commit into
bitcoin:master
from
jonasschnelli:2016/09/rem_maxupt_min
Sep 14, 2016
Merged
Remove maxuploadtargets recommended minimum #8712
jonasschnelli
merged 1 commit into
bitcoin:master
from
jonasschnelli:2016/09/rem_maxupt_min
Sep 14, 2016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 13, 2016
Member
|
utACK 1b6bcdd |
Member
|
Thanks! utACK 1b6bcdd |
Member
|
Tagged for 0.13.1 (Sorry for increasing the backport backlog here, but we have an issue open about this: #8555 and it is pretty much a "Docs and Output"-only change. So minimal risk involved in backporting) |
Contributor
|
utACK 1b6bcdd |
Member
|
utACK 1b6bcdd |
jonasschnelli
added a commit
that referenced
this pull request
Sep 14, 2016
1b6bcdd Remove maxuploadtargets recommended minimum (Jonas Schnelli)
laanwj
pushed a commit
to laanwj/bitcoin
that referenced
this pull request
Sep 26, 2016
Github-Pull: bitcoin#8712 Rebased-From: 1b6bcdd
Member
|
This is backported in #8815, removing tag |
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 11, 2018
1b6bcdd Remove maxuploadtargets recommended minimum (Jonas Schnelli)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
1b6bcdd Remove maxuploadtargets recommended minimum (Jonas Schnelli)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The maxuploadtarget recommended minimum is partially "broken" since the merge of SW (#8555). Addressing and updating the recommendation seems to be difficult (see #8559).
Recommendation are non-trivial because its depending on how we calculate the p2p-network IBD "health".