[copyright] add MIT license headers to .sh scripts where missing #8700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Years are set according to 'git log' history
Contributor
|
ACK Also a perma-ACK from me to add the appropriate license header to all code I have contributed or will contribute to bitcoin/bitcoin. |
Contributor
|
ACK |
2 similar comments
Contributor
|
ACK |
Member
|
ACK |
Member
|
ACK, I think this is ready. |
laanwj
added a commit
that referenced
this pull request
Sep 20, 2016
… missing 0766d1c [copyright] add MIT license headers to .sh scripts where missing (isle2983)
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Sep 21, 2016
Years are set according to 'git log' history Github-Pull: bitcoin#8700 Rebased-From: 0766d1c
This was referenced Sep 22, 2016
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 11, 2018
…s where missing 0766d1c [copyright] add MIT license headers to .sh scripts where missing (isle2983)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
…s where missing 0766d1c [copyright] add MIT license headers to .sh scripts where missing (isle2983)
Merged
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Nov 10, 2020
Lint fixes Fixes most lints currently reported by `test/lint/lint-all.sh`. Includes changes cherry-picked from the following upstream PRs: - bitcoin/bitcoin#8700 - bitcoin/bitcoin#8840 - bitcoin/bitcoin#9867 - We backported the second commit in #3146 - bitcoin/bitcoin#10771 - bitcoin/bitcoin#11394 - bitcoin/bitcoin#11649 - bitcoin/bitcoin#17329 - bitcoin/bitcoin#19258
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a MIT license copyright header for 11 shell scripts (*.sh) in the repo.
Previous discussions of copyright headers are in PR #7300 and #8676. From those discussions, there is a perma-ACK on copyright headers from @MarcoFalke, so it can be assumed here.
So, for the files in this batch, we require an ACK from:
@sipa
@theuni
@jonasschnelli
@luke-jr
@runeksvendsen
@TheBlueMatt
@petertodd
Broken down by individual files:
contrib/devtools/git-subtree-check.sh (@sipa)
contrib/macdeploy/detached-sig-apply.sh (@theuni, @jonasschnelli)
contrib/macdeploy/detached-sig-create.sh (@theuni, @jonasschnelli)
contrib/macdeploy/extract-osx-sdk.sh (@luke-jr)
contrib/qos/tc.sh (@runeksvendsen)
contrib/tidy_datadir.sh (@sipa)
contrib/verify-commits/gpg.sh (@TheBlueMatt)
contrib/verify-commits/pre-push-hook.sh (@TheBlueMatt)
contrib/verify-commits/verify-commits.sh (@TheBlueMatt, @petertodd)
contrib/verifybinaries/verify.sh (@MarcoFalke)
src/qt/res/movies/makespinner.sh (@jonasschnelli, @MarcoFalke)
Like with #8646, after a few days, the files without ACK quorum will be removed and PR'd separately.