[Wallet] Remove last external reference to CWalletDB #8696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
ThreadFlushWalletDB is started from init still, no? |
Contributor
Author
|
@luke-jr yes but that doesn't use CWalletDB and handles something having the database open already just fine. The goal here is to cache the CWalletDB across nested CWallet calls to avoid performance issues. (Similar to what the initial wallet encryption logic does). |
Member
|
utACK 461a760 |
Contributor
|
utACK 461a7600664fe771964fc0bf153004c087bd8004 |
src/wallet/wallet.h
Outdated
Contributor
There was a problem hiding this comment.
Would be kind of nice to not expose DBErrors further from wallet, though I would still call this a strict improvement.
Contributor
Author
There was a problem hiding this comment.
DBErrors is already exposed in CWallet::LoadWallet I'll probably change that later
pstratem
force-pushed
the
2016-09-09-cwallet-listaccountcreditdebit
branch
from
461a760 to
56191f5
Compare
Simple pass through for CWalletDB::ListAccountCreditDebit
pstratem
force-pushed
the
2016-09-09-cwallet-listaccountcreditdebit
branch
from
56191f5 to
bad0a6e
Compare
pstratem
force-pushed
the
2016-09-09-cwallet-listaccountcreditdebit
branch
from
bad0a6e to
2ca6b9d
Compare
laanwj
approved these changes
Sep 20, 2016
| bool AddAccountingEntry(const CAccountingEntry&, CWalletDB & pwalletdb); | ||
| void ListAccountCreditDebit(const std::string& strAccount, std::list<CAccountingEntry>& entries); | ||
| bool AddAccountingEntry(const CAccountingEntry&); | ||
| bool AddAccountingEntry(const CAccountingEntry&, CWalletDB *pwalletdb); |
Contributor
Author
There was a problem hiding this comment.
Maybe, I'm going to go through all of the API calls and make things which can be private private as a sweep.
I'd rather fix this then.
laanwj
added a commit
that referenced
this pull request
Sep 20, 2016
2ca6b9d Remove last reference to CWalletDB from accounting_tests.cpp (Patrick Strateman) 02e2a81 Remove pwalletdb parameter from CWallet::AddAccountingEntry (Patrick Strateman) d2e678d Add CWallet::ReorderTransactions and use in accounting_tests.cpp (Patrick Strateman) 59adc86 Add CWallet::ListAccountCreditDebit (Patrick Strateman)
Member
|
utACK 2ca6b9d |
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 11, 2018
2ca6b9d Remove last reference to CWalletDB from accounting_tests.cpp (Patrick Strateman) 02e2a81 Remove pwalletdb parameter from CWallet::AddAccountingEntry (Patrick Strateman) d2e678d Add CWallet::ReorderTransactions and use in accounting_tests.cpp (Patrick Strateman) 59adc86 Add CWallet::ListAccountCreditDebit (Patrick Strateman)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
2ca6b9d Remove last reference to CWalletDB from accounting_tests.cpp (Patrick Strateman) 02e2a81 Remove pwalletdb parameter from CWallet::AddAccountingEntry (Patrick Strateman) d2e678d Add CWallet::ReorderTransactions and use in accounting_tests.cpp (Patrick Strateman) 59adc86 Add CWallet::ListAccountCreditDebit (Patrick Strateman)
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Aug 12, 2021
[Backport] bitcoin/bitcoin#13825 kill accounts This is a backport of the following commits: - from bitcoin/bitcoin#13825 - pick bitcoin/bitcoin@c9c32e6 - from bitcoin/bitcoin#14023 - pick bitcoin/bitcoin@f0dc850 - from bitcoin/bitcoin#13566 - pick bitcoin/bitcoin@702ae1e - pick bitcoin/bitcoin@cf15761 - pick bitcoin/bitcoin@0f3d6e9 - pick bitcoin/bitcoin@7110c83 - pick bitcoin/bitcoin@ef7bc88 - pick bitcoin/bitcoin@4279da4 - pick bitcoin/bitcoin@c410f41 - from bitcoin/bitcoin#9614 - pick bitcoin/bitcoin@02d9f50 - pick bitcoin/bitcoin@82b7dc3 - from bitcoin/bitcoin#8061 - pick bitcoin/bitcoin@ecb9741 - from bitcoin/bitcoin#6851 - pick bitcoin/bitcoin@3e7c89196c - from bitcoin/bitcoin#8828 - pick bitcoin/bitcoin@86029e7 - from bitcoin/bitcoin#8696 - just the first two commits, as AccountingEntry is going away - pick bitcoin/bitcoin@d2e678d - pick bitcoin/bitcoin@59adc86 - from bitcoin/bitcoin#8028 - pick bitcoin/bitcoin@0fd5997
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the CWalletDB references in account_tests.cpp by adding passthrough functions in CWallet